Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text node compression should consider incoming/outgoing text state #113

Closed
burg opened this issue Oct 13, 2012 · 1 comment
Closed

Text node compression should consider incoming/outgoing text state #113

burg opened this issue Oct 13, 2012 · 1 comment

Comments

@burg
Copy link

@burg burg commented Oct 13, 2012

Text nodes are currently compressed (applying CSS white-space) individually and then combined into TextRuns where possible.

When compressing a text node, the presence of whitespace immediately prior to the text node under consideration should influence whether leading whitespace is condensed. So, some state must be passed between calls to transform_text, either by making it a helper object on the stack, or by passing a by-ref state variable.

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Aug 26, 2014

Fixed by #532.

@mbrubeck mbrubeck closed this Aug 26, 2014
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Take the overflow offset into account for the render targets of composite operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.