Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeline into the constellation crate. #11301

Merged
merged 2 commits into from May 21, 2016
Merged

Move pipeline into the constellation crate. #11301

merged 2 commits into from May 21, 2016

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 20, 2016

Thank you for contributing to Servo! Please replace each [ ] by [X] when the step is complete, and replace __ with appropriate data:

  • ./mach build -d does not report any errors
  • ./mach test-tidy --faster does not report any errors
  • These changes fix #__ (github issue number if applicable).

Either:

  • There are tests for these changes OR
  • These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs, components/constellation/lib.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 20, 2016
@nox
Copy link
Contributor

nox commented May 20, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit c3fe2bd has been approved by nox

@highfive highfive assigned nox and unassigned jdm May 20, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 20, 2016
@jdm
Copy link
Member

jdm commented May 20, 2016

@bors-servo: r-
check_no_unwrap.sh doesn't work anymore.

@jdm jdm added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 20, 2016
@highfive
Copy link

New code was committed to pull request.

@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels May 20, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 20, 2016

Now it does (hi jdm)

@nox
Copy link
Contributor

nox commented May 20, 2016

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 9e4bb47 has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 20, 2016
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #10910) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added S-needs-rebase There are merge conflict errors. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 20, 2016
@bors-servo
Copy link
Contributor

🔒 Merge conflict

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 21, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 21, 2016

@bors-servo r=nox

@bors-servo
Copy link
Contributor

📌 Commit 76fae9f has been approved by nox

@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels May 21, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit 76fae9f with merge 27c457d...

bors-servo pushed a commit that referenced this pull request May 21, 2016
Move pipeline into the constellation crate.

Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy --faster` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

Either:
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because _____

Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11301)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel, mac-dev-unit, mac-rel-css, mac-rel-wpt, windows

@bors-servo bors-servo merged commit 76fae9f into master May 21, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 21, 2016
@Ms2ger Ms2ger deleted the pipeline branch May 23, 2016 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants