Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize of github.com before rendering completes causes scrambled text, graphics #11323

Closed
mikedilger opened this issue May 22, 2016 · 6 comments
Closed

Comments

@mikedilger
Copy link

@mikedilger mikedilger commented May 22, 2016

Using current master, built fresh today, on a gentoo linux x86_64 system, running this:

./mach run --release -- -w http://github.com

seems to work fine if it is not resized until after the first render completes.
screenshot_2016-05-22_13-13-57

But if you resize it (I resize from bottom right corner) before rendering completes, the text and some graphics get quite scrambled.
screenshot_2016-05-22_13-14-42

EDIT: It may not be related to "before rendering completes". It seems to be hit or miss. I cannot consistently reproduce it, but I can reproduce it about 1 out of every 6 tries or so.

@metajack
Copy link
Contributor

@metajack metajack commented May 22, 2016

I assume this is webrender specific. Have you tried without -w?

cc @glennw @pcwalton

@mikedilger
Copy link
Author

@mikedilger mikedilger commented May 22, 2016

Without the -w I can't get it to happen, so yes probably webrender.

@kilobtye
Copy link
Contributor

@kilobtye kilobtye commented May 23, 2016

I can confirm this issue. And I would like to look into this issue.

@metajack
Copy link
Contributor

@metajack metajack commented May 23, 2016

@kilobtye Feel free to investigate. It's likely caused by the texture caches getting misused in webrender I think. Ping gw (@glennw) and @pcwalton in IRC if you have specific questions.

@kilobtye
Copy link
Contributor

@kilobtye kilobtye commented May 24, 2016

Thanks @metajack , it is about texture cache.
This issue is caused by text-shadow. Resize changes font-size and does text-shadow. Then

  1. texture blur allocates textures but does not free.
  2. texture becomes full and grows its size and messes up.
    I will submit a PR to fix a bug in 2, that should fix this issue.
@metajack
Copy link
Contributor

@metajack metajack commented May 24, 2016

Excellent sleuthing!

bors-servo added a commit to servo/webrender that referenced this issue May 24, 2016
Update texture size properly when grow texture

This should fix servo/servo#11323
pcwalton added a commit to pcwalton/servo that referenced this issue May 24, 2016
bors-servo added a commit that referenced this issue May 25, 2016
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue May 25, 2016
Update WebRender.

Picks up fixes for #11150, #11151, #11323, and #11327.

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11379)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.