ScriptToCompositorMsg messages should probably be sent to the constellation instead

[Ms2ger]

CC @pcwalton @glennw @larsbergstrom

This is assuming the compositor should be a global structure rather than per-top-level-browsing-context; correct me if that's wrong.

None of these seem like they should be global:

pub enum ScriptToCompositorMsg {
    /// Scroll a page in a window
    ScrollFragmentPoint(PipelineId, LayerId, Point2D<f32>, bool),
    /// Set title of current page
    /// https://html.spec.whatwg.org/multipage/#document.title
    SetTitle(PipelineId, Option<String>),
    /// Send a key event
    SendKeyEvent(Key, KeyState, KeyModifiers),
    /// Get Window Informations size and position
    GetClientWindow(IpcSender<(Size2D<u32>, Point2D<i32>)>),
    /// Move the window to a point
    MoveTo(Point2D<i32>),
    /// Resize the window to size
    ResizeTo(Size2D<u32>),
    /// Script has handled a touch event, and either prevented or allowed default actions.
    TouchEventProcessed(EventResult),
    /// Get Scroll Offset
    GetScrollOffset(PipelineId, LayerId, IpcSender<Point2D<f32>>),
    /// Requests that the compositor shut down.
    Exit,
    /// Allow the compositor to free script-specific resources.
    Exited,
}

[pcwalton]

So ultimately I think that there should be multiple compositors, when we have multiple windows. But that's orthogonal to this proposal.

I think you're absolutely right; these should be constellation messages.

[jdm]

As in they should be sent to the constellation, then sent to the compositor? Why?

[pcwalton]

In case the page is in an iframe or in a background tab, etc, I would think.