Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a mapping between original DOM text and compressed layout text #114

Closed
burg opened this issue Oct 13, 2012 · 2 comments
Closed

Create a mapping between original DOM text and compressed layout text #114

burg opened this issue Oct 13, 2012 · 2 comments
Labels
A-platform/shaping I-enhancement I-wrong

Comments

@burg
Copy link

@burg burg commented Oct 13, 2012

When a user selects text (in the Future™), what's exposed to JS code are the offsets into original text nodes represented by the rendered text that was selected. For example, JavaScript would see any whitespace or newlines that got compressed during TextRun scanning.

In order to implement text selection correctly, there must be a mapping between original DOM text node offsets and compressed text offsets. In Gecko, this is implemented by the gfxSkipChars and gfxSkipCharsIterator structures.

More information:
@burg burg mentioned this issue Oct 18, 2012
Closed
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 24, 2016

This is now done using the various byte-range-to-glyph-slice mapping functions.
@mbrubeck mbrubeck closed this May 24, 2016
@perlun
Copy link
Contributor

@perlun perlun commented May 24, 2016

Wow, that was an old one! 👏
@Manishearth Manishearth mentioned this issue Jun 11, 2016
Merged
2 of 4 tasks complete
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
e2f1f64 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
40d5432 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
5e6bbd3 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
fba0b5e 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
074c807 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 12, 2016
@bors-servo
Auto merge of #11556 - Manishearth:make-fetch-happen, r=jdm
Loading status checks…
0c11e83 
Make fetch happen

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: #114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11556)
<!-- Reviewable:end -->
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
@glennw
Merge pull request servo#114 from pcwalton/composite-blending
82fe72e 
Fix incorrect composite blending.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #11556 - Make fetch happen (from Manishearth:make-fetch-…
0d3aac7 
…happen); r=jdm

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: servo/servo#114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c11e8340b26aa86faf9ea40aae253392b338ba3

UltraBlame original commit: 291f43a19a85aa92d5a3bbb452ee7ac8013a915a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #11556 - Make fetch happen (from Manishearth:make-fetch-…
bb1a34b 
…happen); r=jdm

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: servo/servo#114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c11e8340b26aa86faf9ea40aae253392b338ba3

UltraBlame original commit: 291f43a19a85aa92d5a3bbb452ee7ac8013a915a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
@marco-c
servo: Merge #11556 - Make fetch happen (from Manishearth:make-fetch-…
738b1cc 
…happen); r=jdm

<!-- Please describe your changes on the following line: -->
Moves XHR over to the fetch backend.

Previous PR: servo/servo#114

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors (Will fix later)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0c11e8340b26aa86faf9ea40aae253392b338ba3

UltraBlame original commit: 291f43a19a85aa92d5a3bbb452ee7ac8013a915a
@jdm jdm mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-platform/shaping I-enhancement I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@mbrubeck @burg @perlun
You can’t perform that action at this time.