Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some webdriver_handlers functions ignore their pipeline id argument #11415

Closed
Ms2ger opened this issue May 25, 2016 · 3 comments
Closed

Some webdriver_handlers functions ignore their pipeline id argument #11415

Ms2ger opened this issue May 25, 2016 · 3 comments
Assignees

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 25, 2016

All these functions are called with the top-level browsing context and the pipeline id of the browsing context they care about. Some functions (and the Parent branch of handle_get_frame_id) just use the top-level browsing context instead.

Are we already able to write tests for these functions?

CC @jgraham @asajeffrey

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented May 25, 2016

We can test using the wdspec tests (https://github.com/w3c/web-platform-tests/tree/master/webdriver). The current wptrunner includes a servo wdspec test runner (don't think it's made its way to the servo copy though).

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented May 25, 2016

The webdriver code probably needs rewritten to use FrameId rather than PipielineId. The selection of top-level browsing context makes a big difference in the context of browser.html: #11256.

@asajeffrey asajeffrey self-assigned this May 25, 2016
@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 22, 2017

Fixed by #16997, which replaced the uses of pipeline ids by top-level browsing context ids.

@asajeffrey asajeffrey closed this Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.