Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome webdriver_handlers functions ignore their pipeline id argument #11415
Labels
Comments
|
We can test using the wdspec tests (https://github.com/w3c/web-platform-tests/tree/master/webdriver). The current wptrunner includes a servo wdspec test runner (don't think it's made its way to the servo copy though). |
|
The webdriver code probably needs rewritten to use FrameId rather than PipielineId. The selection of top-level browsing context makes a big difference in the context of browser.html: #11256. |
|
Fixed by #16997, which replaced the uses of pipeline ids by top-level browsing context ids. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All these functions are called with the top-level browsing context and the pipeline id of the browsing context they care about. Some functions (and the
Parentbranch ofhandle_get_frame_id) just use the top-level browsing context instead.Are we already able to write tests for these functions?
CC @jgraham @asajeffrey