Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to enable content blocker for a specific top level browsing context #11500

Open
paulrouget opened this issue May 30, 2016 · 5 comments
Open

Add an option to enable content blocker for a specific top level browsing context #11500

paulrouget opened this issue May 30, 2016 · 5 comments
Labels
A-content/dom A-network

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented May 30, 2016

The same way we have <iframe mozprivatebrowsing>, we could have <iframe mozcontentblocker> to toggle the content blocker mechanism.

/cc @nox @jdm
This was referenced May 30, 2016
Merged
Closed
@nox
Copy link
Member

@nox nox commented Jun 2, 2016

I'm waiting on #11544 to land before working on this, since I will leverage the same code paths from that PR.
@nox nox self-assigned this Jun 2, 2016
@nox nox added the C-assigned label Jun 20, 2016
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 21, 2016

@nox #11544 has landed.
@nox nox removed the C-assigned label Aug 18, 2016
@nox nox removed their assignment Aug 18, 2016
@nox
Copy link
Member

@nox nox commented Mar 4, 2017

This can probably be made into an E-Easy.
@ferjm ferjm self-assigned this Mar 6, 2017
@ferjm ferjm added the C-assigned label Mar 6, 2017
@ferjm ferjm mentioned this issue Mar 6, 2017
Closed
3 of 4 tasks complete
@ferjm
Copy link
Member

@ferjm ferjm commented Mar 7, 2017

It seems that the content blocker needs to be rewritten in #14307 (or maybe with a different approach as suggested by @fabricedesre). And until this is done, it makes no sense to add the iframe attribute.
@ferjm ferjm removed their assignment Mar 7, 2017
@ferjm ferjm removed the C-assigned label Mar 7, 2017
@paulrouget paulrouget changed the title Add an attribute to iframe to toggle mozcontentblocker Add an option to enable content blocker for a specific top level browsing context Jun 6, 2018
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 6, 2018

browserhtml is not more. Updating the title according.

We still want to be able to toggle content blocking for a specific tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom A-network
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

WIP - Add an attribute to iframe to toggle mozcontentblocker
4 participants
@jdm @nox @paulrouget @ferjm
You can’t perform that action at this time.