Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default font-size in <input> is not correct. #11529

Closed
ocerman opened this issue May 31, 2016 · 7 comments
Closed

Default font-size in <input> is not correct. #11529

ocerman opened this issue May 31, 2016 · 7 comments
Labels
A-layout/inline A-layout/text C-assigned C-has-manual-testcase E-easy

Comments

@ocerman
Copy link

@ocerman ocerman commented May 31, 2016

Default font-size in Input like <input type="text" value="123" style="font-family: Arial"> is smaller in Servo compared to Firefox and other browsers.
fsize
@KiChjang
Copy link
Member

@KiChjang KiChjang commented May 31, 2016 •
edited

It looks to me that this can easily be fixed by changing resources/user-agent.css to use a bigger font size on input elements, but I'm not 100% sure.
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 31, 2016 •
edited

We explicitly set the font size for inputs here:

servo/resources/servo.css

Line 11 in 55b0bb0

font-size: 0.7em;

The servo.css file contains "internal" styles for rendering things like form controls, since we don't have any support for native form widgets. I think these styles are arbitrary, not specified by any standard.

We currently use 0.7em for inputs, which computes to 11.2px by default. Firefox renders at 13.333px by default, which might correspond to 0.8333em.
@KiChjang KiChjang added the E-easy label May 31, 2016
@highfive
Copy link

@highfive highfive commented May 31, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@Coder206
Copy link
Contributor

@Coder206 Coder206 commented May 31, 2016

I would love to as soon as I complete #11450
@jdm
Copy link
Member

@jdm jdm commented Jun 1, 2016

We'll leave this unassigned until someone says they're ready to start working on it :)
@taravancil
Copy link
Contributor

@taravancil taravancil commented Jun 1, 2016

I'll work on this! I'll let y'all know if I have questions along the way.
@taravancil taravancil mentioned this issue Jun 1, 2016
Merged
4 of 5 tasks complete
@jdm jdm added the C-assigned label Jun 1, 2016
@jdm
Copy link
Member

@jdm jdm commented Jun 1, 2016

It's yours!
bors-servo added a commit that referenced this issue Jun 2, 2016
@bors-servo
Auto merge of #11540 - taravancil:input-text-size, r=mbrubeck
Loading status checks…
592842c 
Change the font-size property for input and textarea

Change the `font-size` property for `input` and `textarea` from 0.7em to 0.8333em.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11529 (github issue number if applicable).

- [ ] There are tests for these changes OR
- [X] These changes do not require tests because the issue has the label `C-has-test` Forgive me if I'm wrong; this is my first time contributing to Servo!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11540)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline A-layout/text C-assigned C-has-manual-testcase E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Change the font-size property for input and textarea
7 participants
@mbrubeck @jdm @KiChjang @highfive @taravancil @Coder206 @ocerman
You can’t perform that action at this time.