Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URL.domainToUnicode #11629

Closed
nox opened this issue Jun 5, 2016 · 4 comments
Closed

Implement URL.domainToUnicode #11629

nox opened this issue Jun 5, 2016 · 4 comments
Labels
A-content/dom C-assigned E-easy

Comments

@nox
Copy link
Member

@nox nox commented Jun 5, 2016

The implementation of URL.domainToUnicode can just use url::quirks::domain_to_unicode.

The operation needs to be uncommented in components/script/dom/webidls/URL.webidl and a new static method DomainToUnicode needs to be implemented in components/script/dom/url.rs.

The test expectations also need to be changed.

./mach test-wpt --no-pause --log-raw raw.log /url/interfaces.html
./mach update-wpt --no-patch raw.log

Files:

  • components/script/dom/url.rs
  • components/script/dom/webidls/URL.webidl
  • tests/wpt/metadata/url/interfaces.html.ini
@highfive
Copy link

@highfive highfive commented Jun 5, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@nox
Copy link
Member Author

@nox nox commented Jun 5, 2016

@SimonSapin Do we test this in rust-url?
@Ms2ger @jdm Do we want additional tests in WPT? Can't see one apart from the usual interfaces.html test.
@achals
Copy link
Contributor

@achals achals commented Jun 6, 2016

I'll work on this if no one else already is.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jun 6, 2016

You got it!
@KiChjang KiChjang added the C-assigned label Jun 6, 2016
@achals achals mentioned this issue Jun 6, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jun 6, 2016
@bors-servo
Auto merge of #11632 - achals:master, r=KiChjang
Loading status checks…
21687b0 
Implement URL.domainToUnicode

Fixes #11629

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11629  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes: Some expected test failures have been removed.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11632)
<!-- Reviewable:end -->
@clarkbw clarkbw mentioned this issue Aug 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement URL.domainToUnicode
4 participants
@nox @achals @KiChjang @highfive
You can’t perform that action at this time.