Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hittest] Link hitboxes are not updated after scrolling on duckduckgo #11648

Closed
cbrewster opened this issue Jun 7, 2016 · 2 comments
Closed

[hittest] Link hitboxes are not updated after scrolling on duckduckgo #11648

cbrewster opened this issue Jun 7, 2016 · 2 comments
Labels
A-webrender C-has-manual-testcase

Comments

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Jun 7, 2016

./mach run -d -w https://duckduckgo.com/\?q\=rust+langauge
Scroll down and hover over links. The link rectangles are not updated after the scroll.
This happens both inside and outside of browserhtml.
This only happens with webrender.
@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 7, 2016

Could is be a regression due to #11537 ?
@paulrouget paulrouget mentioned this issue Jun 7, 2016
Merged
@paulrouget paulrouget changed the title Link hitboxes are not updated after scrolling on duckduckgo [hittest] Link hitboxes are not updated after scrolling on duckduckgo Jun 7, 2016
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jun 8, 2016

Minimal test case:

<!DOCTYPE html>
<html style="overflow: scroll"><body style="padding-top: 1200px"><a href="http://example.com">Mouse over me</a></body></html>
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 9, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
90932e0 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
@pcwalton pcwalton mentioned this issue Jun 9, 2016
Merged
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 9, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
6010cb3 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
@pcwalton pcwalton mentioned this issue Jun 9, 2016
Closed
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 10, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
22ff188 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 10, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
5afc4db 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 10, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
78a11e4 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
pcwalton added a commit to pcwalton/servo that referenced this issue Jun 11, 2016
@pcwalton
script: When using WebRender, keep the DOM-side scroll positions for
041cfe6 
elements with `overflow: scroll` up to date, and take them into account
when doing hit testing.

Closes servo#11648.
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11680 - pcwalton:wr-overflow-scroll-hit-testing, r=jdm
ffcf72d 
script: When using WebRender, keep the DOM-side scroll positions for elements with `overflow: scroll` up to date, and take them into account when doing hit testing.

Closes #11648.

r? @jdm
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11680)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 11, 2016
@bors-servo
Auto merge of #11680 - pcwalton:wr-overflow-scroll-hit-testing, r=jdm
Loading status checks…
2d93380 
script: When using WebRender, keep the DOM-side scroll positions for elements with `overflow: scroll` up to date, and take them into account when doing hit testing.

Closes #11648.

r? @jdm
cc @paulrouget

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11680)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-webrender C-has-manual-testcase
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@pcwalton @paulrouget @cbrewster
You can’t perform that action at this time.