Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename [Re]RenderMsg #1165

Closed
kmcallister opened this issue Nov 1, 2013 · 4 comments
Closed

Rename [Re]RenderMsg #1165

kmcallister opened this issue Nov 1, 2013 · 4 comments
Labels
E-easy I-papercut I-refactor

Comments

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Nov 1, 2013

See discussion on #140.
@zmike
Copy link
Contributor

@zmike zmike commented Jan 6, 2014

I can do this today. I would propose the following:

RenderMsg -> LayoutRenderMsg
ReRenderMsg -> CompositorRenderMsg

I guess once the names are agreed upon this will be fairly trivial.
@lpy
Copy link
Contributor

@lpy lpy commented Feb 9, 2014

Could I take this issue? @zmike , are you still working on this?
@gilles-leblanc
Copy link
Contributor

@gilles-leblanc gilles-leblanc commented Sep 3, 2014

Has far as I can tell ReRenderMsg has been renamed since it is no longer found in the source code. RenderMsg is still present albeit the original discussion in #140 specifically mentioned ReRenderMsg as being problematic and I feel it was more confusing than RenderMsg is.

Is this issue considered close because of the rename of ReRenderMsg? If not, I will volunteer to rename RenderMsg.
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 3, 2014

I would consider this closed.
@pcwalton pcwalton closed this Sep 3, 2014
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@zcorpan
Merge pull request servo#1165 from Ms2ger/html-interfaces
1ddb999 
Remove a duplicated definition of HTMLScriptElement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy I-papercut I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@pcwalton @zmike @kmcallister @gilles-leblanc @lpy
You can’t perform that action at this time.