Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe with 3D transform, content not clipped #11650

Closed
paulrouget opened this issue Jun 7, 2016 · 3 comments
Closed

Iframe with 3D transform, content not clipped #11650

paulrouget opened this issue Jun 7, 2016 · 3 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jun 7, 2016

Even though both #11151 and #11358 are now fixed, we still have issues with iframe content not being properly clipped.

Both previous test case render correctly, so it's something new.

Working on a reduced test case now.

screen shot 2016-06-07 at 07 51 46

@paulrouget paulrouget changed the title Iframe content not clipped, again Iframe with 3D transform, content not clipped Jun 7, 2016
@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jun 7, 2016

It's 3D transform specific:

<style>
  div, iframe {
    width: 100vw;
    height: 100vh;
    top: 0px;
    left: 0px;
  }
  div {
    perspective: 1000px;
    background: grey;
  }
  iframe {
    display: block;
    transform-origin: left center 0px;
    transform: translate3d(0px, 0px, -200px);
  }
</style>

<div>
  <iframe src="https://duckduckgo.com/?q=foobar&amp;ia=about">
  </iframe>
</div>

@pcwalton any ideas? If that's too hard to fix, I think we can simply move to 2D transforms in browserhtml.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jun 9, 2016

I think this is probably something related to DDG's specific use of stacking contexts, similar to #11648.

pcwalton added a commit to pcwalton/webrender that referenced this issue Jun 10, 2016
transform/perspective and world transform/perspective.

Addresses servo/servo#11650.
bors-servo added a commit to servo/webrender that referenced this issue Jun 13, 2016
Rewrite the flatten transform/clip code to more clearly separate local transform/perspective and world transform/perspective.

Addresses servo/servo#11650.

r? @glennw
bors-servo added a commit to servo/webrender that referenced this issue Jun 20, 2016
Rewrite the flatten transform/clip code to more clearly separate local transform/perspective and world transform/perspective.

Addresses servo/servo#11650.

r? @glennw
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Aug 3, 2016

This appears to be fixed with WR2 #12711

@cbrewster cbrewster closed this Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.