Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of twitter login page is abysmal #11659

Closed
jdm opened this issue Jun 7, 2016 · 5 comments
Closed

Performance of twitter login page is abysmal #11659

jdm opened this issue Jun 7, 2016 · 5 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Jun 7, 2016

Trying to type my username into the input box is a multi-second affair, with the display not updating for long periods of time. A profile trace shows 2.3 seconds for a "Painting" operation, with "PaintingPerTitle" operations taking >1s.

./mach run https://twitter.com/login

http://www.joshmatthews.net/twitter-login-trace.html

@metajack
Copy link
Contributor

@metajack metajack commented Jun 7, 2016

cc @pcwalton

With those kind of timings, this may be diagnosable with Instruments.app.

@jdm
Copy link
Member Author

@jdm jdm commented Jun 7, 2016

Instruments reports 16.7% under PaintContext::draw_box_shadow (for 6 separate threads). Of that, 15.8% under PaintContext::blur_if_necessary, which ends up spending 12.2% under mozilla::gfx::AlphaBoxBlur::Blur, which is entirely spent in mozilla::gfx::AlphaBoxBlur::BoxBlur_SSE2.

@jdm
Copy link
Member Author

@jdm jdm commented Jun 7, 2016

I can't test with webrender due to #11658.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jun 7, 2016

I don't think it would be a good use of time to fix the non-WR path. Let's fix the WR crash.

@nox
Copy link
Member

@nox nox commented Oct 2, 2017

This doesn't seem to happen anymore.

@nox nox closed this Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.