Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get window.frameElement to return null #11660

Closed
asajeffrey opened this issue Jun 7, 2016 · 2 comments
Closed

Get window.frameElement to return null #11660

asajeffrey opened this issue Jun 7, 2016 · 2 comments
Assignees
@asajeffrey
Labels
A-content/script

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jun 7, 2016

#11644 adds Window::is_top_level, which should be used by Window::GetFrameElement to return null approporiately in a mozbrowser. cc @ConnorGBrewster
@asajeffrey asajeffrey self-assigned this Jun 7, 2016
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jun 7, 2016

There may also need to be some work around x-origin iframes.
@asajeffrey asajeffrey mentioned this issue Mar 2, 2017
Merged
4 of 4 tasks complete
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Mar 2, 2017

Will be fixed when #15799 lands.
bors-servo added a commit that referenced this issue Mar 17, 2017
@bors-servo
Auto merge of #15799 - asajeffrey:script-window-xorigin-parent, r=nox
Loading status checks…
0a3b373 
Implement dissimilar-origin window.parent and window.top

<!-- Please describe your changes on the following line: -->

This PR implements `window.parent` and `window.top` for dissimilar-origin windows.

This PR builds on #15536, only the last commit is part of this PR.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14996 and fix #11660.
- [X] These changes do not require tests because there's already a parentage test in `mozilla/cross-origin-objects/cross-origin-objects.html`.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15799)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
A-content/script
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Implement dissimilar-origin window.parent and window.top
1 participant
@asajeffrey
You can’t perform that action at this time.