Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused XHR method #11760

Closed
nox opened this issue Jun 16, 2016 · 7 comments
Closed

Remove unused XHR method #11760

nox opened this issue Jun 16, 2016 · 7 comments
Labels
C-assigned E-easy I-cleanup

Comments

@nox
Copy link
Member

@nox nox commented Jun 16, 2016 

warning: method is never used: `insert_trusted_header`, #[warn(dead_code)] on by default
    --> /Users/nox/src/servo/components/script/dom/xmlhttprequest.rs:1044:5
     |>
1044 |>     fn insert_trusted_header(&self, name: String, value: String) {
     |>     ^
@highfive
Copy link

@highfive highfive commented Jun 16, 2016

Please make a comment here if you intend to work on this issue. Thank you!
@mrmiywj
Copy link
Contributor

@mrmiywj mrmiywj commented Jun 16, 2016

I'll work on this.
@jdm
Copy link
Member

@jdm jdm commented Jun 16, 2016

We should leave this for someone else. You've got enough Servo experience to work on something less straightforward.
@splav
Copy link
Contributor

@splav splav commented Jun 17, 2016

May I take this?
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jun 17, 2016

You may.
@jdm jdm added the C-assigned label Jun 17, 2016
@jdm jdm mentioned this issue Jun 17, 2016
Merged
2 of 4 tasks complete
@splav splav mentioned this issue Jun 17, 2016
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jun 17, 2016
@bors-servo
Auto merge of #11769 - splav:master, r=jdm
3332e1a 
Remove unused XHR method

<!-- Please describe your changes on the following line: -->
Remove unused XHR method.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11760 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11769)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jun 17, 2016
@bors-servo
Auto merge of #11769 - splav:master, r=jdm
Loading status checks…
fb9f327 
Remove unused XHR method

<!-- Please describe your changes on the following line: -->
Remove unused XHR method.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11760 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is a cleanup

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11769)
<!-- Reviewable:end -->
@mrmiywj
Copy link
Contributor

@mrmiywj mrmiywj commented Jun 17, 2016

@jdm
Sure!
I'm glad to hear that! Could you offer any suggestion for large project I can do for Servo?
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jun 17, 2016 •
edited

@mrmiywj Have you looked at the B-interesting-project tag? #5236 is also a good way to get more involved with the inner workings of Servo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Remove unused XHR method
7 participants
@jdm @Ms2ger @nox @splav @KiChjang @highfive @mrmiywj
You can’t perform that action at this time.