Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove network monitor integration #11773
Comments
|
cc @fitzgen |
|
Thanks! |
|
@jdm
But actually, I found that components/net/http_loader.rs L967 every time the browser sends out a request, it will also generate a (msg, response). What's the purpose of |
|
@mrmiywj Note that we don't send the message to the devtools until https://github.com/servo/servo/blob/master/components/net/http_loader.rs#L1061 . In between there are several places where we restart the loop and never send the message. The purpose of creating a new request ID would be to ensure that each message the devtools receives for a separate request gets a separate ID. |
send requests that are redirected to devtools <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11773 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because no automating tests <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11889) <!-- Reviewable:end -->
#11593 made the network monitor appear when using the Firefox developer tools with Servo. There are some known problems with the output that it shows, however:
https://reddit.comand getting redirected tohttps://www.reddit.com)I'm not sure how to solve the problem with the response panel yet, but the others will require modifying the code in
http_loader.rsto send more notifications to the developer tools server. For the missing requests, we should be creating a new request ID each time and sending the information about the request and response sooner. For the missing timing data, we will need to time how long receiving the full HTTP response body takes and send a message to the developer tools that reports it.Code:
components/net/http_loader.rs,components/devtools_traits/lib.rs,components/devtools/lib.rs,components/devtools/actors/network_event.rscc @mrmiywj This might be interesting to you.