Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInclude warnings in crash reports #11776
Closed
Assignees
Labels
Comments
This was referenced Jun 23, 2016
bors-servo
added a commit
that referenced
this issue
Jul 15, 2016
Send log messages to the constellation <!-- Please describe your changes on the following line: --> Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics. Note that this can't merge yet, as it needs rust-lang/log#86 to land. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11776 (github issue number if applicable). - [X] These changes do not require tests because we don't test crash reporting. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11841) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 15, 2016
Send log messages to the constellation <!-- Please describe your changes on the following line: --> Send all warnings and errors to the constellation. Warnings are bufferred up, and included in any subsequent error reports. Errors are reported in the same way as panics. Note that this can't merge yet, as it needs rust-lang/log#86 to land. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11776 (github issue number if applicable). - [X] These changes do not require tests because we don't test crash reporting. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11841) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should buffer up
warn!, and send an error report onerror!as well as panic. (We need to make sure that privacy-sensitive data doesn't end up in crash reports, possibly using types/traits to track privacy.)cc @paulrouget