Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to euclid 0.7 #11813
Update to euclid 0.7 #11813
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
@SimonSapin I don't see the euclid dependency in the Cargo.toml file at https://github.com/servo/app_units Does it need to be added? |
|
servo/app_units@e025228 removed it. |
|
@SimonSapin Are there any tests required before submitting code? |
|
If it builds, that's good enough. |
|
@jdm Cool. |
|
Since the euclid dependency was removed from app_units, there is nothing to do in that repository for this issue. |
|
Or rather, the only thing to do is update |
Upgrade version of euclid crate This is related to [this servo issue](servo/servo#11813) to update euclid on servo's dependencies. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/229) <!-- Reviewable:end -->
|
|
Update euclid dependency This is related to [this servo issue](servo/servo#11813) to update euclid on servo's dependencies. I tried to [updating it on rust-azure](servo/rust-azure#229), but I got a build problem related to skia. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/skia/98) <!-- Reviewable:end -->
Upgrade version of euclid crate This is related to [this servo issue](servo/servo#11813) to update euclid on servo's dependencies. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/229) <!-- Reviewable:end -->
|
I think this can be closed, @nox seems to have got them. |
|
Yes. |
We made a semver-breaking version bump of https://crates.io/crates/euclid for a change (requires
T: Cloneof serde impls) that is technically breaking but probably doesn’t affect any users. Therefore, updating likely only involves updatingCargo.tomlfiles. I’ve made the changes in this repository at https://github.com/servo/servo/compare/euclidup, but to satisfy./mach test-tidythe dependencies also need to be updated: