Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntermittent failure of etc/ci/manifest_changed.sh #11859
Closed
Labels
Comments
This was referenced Jun 25, 2016
Merged
This was referenced Jun 27, 2016
Merged
bors-servo
added a commit
that referenced
this issue
Jun 27, 2016
Investigating #11859 (do not merge!) <!-- Please describe your changes on the following line: --> This makes sure that manifest_changed.sh fails. Just checking to see if the diff is printed on the builders. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Looks like this is actually a duplicate of #11858, based on my on-builder debugging:
|
|
@jdm: we did start seeing them both at the same time, so it wouldn't be too surprising if it's the same root cause. |
bors-servo
added a commit
that referenced
this issue
Jun 27, 2016
Fix common OpenSSL intermittent failure on automated builders OpenSSL requires that the digits of the serial number for the generated certs contain an even number of digits. The recent change in sslutils (w3c/wpt-tools@b388d6b) does not fulfill this requirement. I'll be making the same PR upstream to address that, but this will get us out of the woods locally. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #11858 and fix #11859 - [X] These changes do not require tests because there's no automated testing for the SSL cert generation <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11885) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http://build.servo.org/builders/android/builds/1563