Double-free (?) in NativePaintingGraphicsContext::drop

[kmcallister]

Crash on exit. Linux, Intel graphics, GPU rendering. Can't reproduce with -c. Won't happen if the window has never been resized.

*** glibc detected *** ./servo: double free or corruption (fasttop): 0x00007f9d391c14a0 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x76d76)[0x7f9d3e486d76]
/lib/x86_64-linux-gnu/libc.so.6(cfree+0x6c)[0x7f9d3e48baac]
/usr/lib/x86_64-linux-gnu/dri/i965_dri.so(+0x24f240)[0x7f9d3571d240]
/usr/lib/x86_64-linux-gnu/dri/i965_dri.so(+0x22cc49)[0x7f9d356fac49]
/usr/lib/x86_64-linux-gnu/dri/i965_dri.so(+0x87dde)[0x7f9d35555dde]
/usr/lib/x86_64-linux-gnu/libGL.so.1(+0x463d2)[0x7f9d3fa873d2]
/usr/lib/x86_64-linux-gnu/libGL.so.1(+0x22796)[0x7f9d3fa63796]
/usr/lib/x86_64-linux-gnu/libGL.so.1(+0x22819)[0x7f9d3fa63819]
/usr/lib/x86_64-linux-gnu/libGL.so.1(+0x22925)[0x7f9d3fa63925]
/usr/lib/x86_64-linux-gnu/libX11.so.6(XCloseDisplay+0xa2)[0x7f9d402dfff2]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/support/layers/rust-layers/liblayers-ff612b1d22eecf52-0.1.so(_ZN8platform5linux7surface34Drop$NativePaintingGraphicsContext4drop21h24e78de19af325e9yTan4v0.1E+0x45)[0x7f9d42b12fb5]
./servo[0x55330a]
./servo[0x5639ac]
./servo[0x549f62]
./servo[0x547864]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-6c65cf4b443341b1-0.9-pre.so(+0xe3855)[0x7f9d425b2855]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-6c65cf4b443341b1-0.9-pre.so(+0x1418ce)[0x7f9d426108ce]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-6c65cf4b443341b1-0.9-pre.so(+0x13f953)[0x7f9d4260e953]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/librustrt.so(rust_try+0x13)[0x7f9d3f5e31d3]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-6c65cf4b443341b1-0.9-pre.so(_ZN2rt4task4Task3run21h199ab8d6eb2269804van11v0.9$x2dpreE+0x77)[0x7f9d4260e677]
/home/keegan/proj/servo/servo/build.debug/x86_64-unknown-linux-gnu/src/compiler/rust/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-6c65cf4b443341b1-0.9-pre.so(+0x14147a)[0x7f9d4261047a]

[kmcallister]

This happens inside XCloseDisplay and so might be the same underlying issue as #1157.

[larsbergstrom]

Fixed by #1487

NVidia drivers get very upset if you do not share the same X11 connection.