Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle video metadata #11882

Closed
GuillaumeGomez opened this issue Jun 27, 2016 · 13 comments
Closed

Handle video metadata #11882

GuillaumeGomez opened this issue Jun 27, 2016 · 13 comments

Comments

@GuillaumeGomez
Copy link
Contributor

@GuillaumeGomez GuillaumeGomez commented Jun 27, 2016

An integration can be made here with the video-metadata-rs crate.

However, like said in the README, video-metadata-rs is using the version 3.x of FFMPEG libraries. So the libs have to be built and installed manually (well, I guess it's not really an issue but I prefer to make a note about it). I think it could get downgraded to 2.x version quite easily but I think it's better to use lastest version.

I think I resumed all information about it. If you think I forgot something, please tell me! 😃

I'll start to work on it in the next days.

cc @jdm

@jdm jdm added the A-content/dom label Jun 27, 2016
@jdm
Copy link
Member

@jdm jdm commented Jun 27, 2016

If they're available in standard package managers (apt, dnr, brew, and mingw) then it shouldn't be a problem. Otherwise, it's going to be more difficult, since at minimum there's the cross-platform automated builders to consider.

@GuillaumeGomez
Copy link
Contributor Author

@GuillaumeGomez GuillaumeGomez commented Jun 27, 2016

That was my point. Otherwise I'll create a 2.8 branch.

@GuillaumeGomez
Copy link
Contributor Author

@GuillaumeGomez GuillaumeGomez commented Jun 27, 2016

Ah great news, there are packages for linux, OSX and windows!

@est31
Copy link
Contributor

@est31 est31 commented Jul 31, 2016

It supports reading metadata of all major codecs inside the Ogg container (opus, vorbis, theora): https://github.com/est31/ogg-metadata

@clstl
Copy link
Contributor

@clstl clstl commented Jul 31, 2016

Had issues compiling on OSX El Capitan today. Had to build ffmpeg from sources and soft link it, so that cargo sees it. The new Homebrew version puts everything in /usr/local (having it in PATH does not seem to help)

@GuillaumeGomez
Copy link
Contributor Author

@GuillaumeGomez GuillaumeGomez commented Jul 31, 2016

@clstl: Some people reported this issue here.

@clstl
Copy link
Contributor

@clstl clstl commented Aug 1, 2016

@GuillaumeGomez I cloned from master a few hours ago and the issue was present. Some more people have it as well on OS X.
here

@metajack
Copy link
Contributor

@metajack metajack commented Aug 1, 2016

The issue is that while pkg-config is used to determine if the libraries are there, it only uses the linking information, not the include directories. We just need to add those. I'm working on a patch now.

@nox
Copy link
Member

@nox nox commented Sep 29, 2017

The crate audio-video-metadata currently returns informations about a single track in the passed media, it should return informations about all of them.

@GuillaumeGomez
Copy link
Contributor Author

@GuillaumeGomez GuillaumeGomez commented Sep 29, 2017

I'm gonna need to take a look (it should return all tracks).

@est31
Copy link
Contributor

@est31 est31 commented Sep 29, 2017

@GuillaumeGomez my ogg metadata crate should return all tracks it can find. If that doesn't work or its not enough, please say so!

@GuillaumeGomez
Copy link
Contributor Author

@GuillaumeGomez GuillaumeGomez commented Sep 29, 2017

I think the error comes from audio-video-metadata. I'll need to investigate!

@ferjm
Copy link
Member

@ferjm ferjm commented Nov 29, 2018

IIUC this was fixed with the addition of servo-media. Please, reopen if you consider that this issue is still valid.

@ferjm ferjm closed this Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.