Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle video metadata #11882
Handle video metadata #11882
Comments
|
If they're available in standard package managers (apt, dnr, brew, and mingw) then it shouldn't be a problem. Otherwise, it's going to be more difficult, since at minimum there's the cross-platform automated builders to consider. |
|
That was my point. Otherwise I'll create a 2.8 branch. |
|
It supports reading metadata of all major codecs inside the Ogg container (opus, vorbis, theora): https://github.com/est31/ogg-metadata |
|
Had issues compiling on OSX El Capitan today. Had to build ffmpeg from sources and soft link it, so that cargo sees it. The new Homebrew version puts everything in /usr/local (having it in PATH does not seem to help) |
|
@GuillaumeGomez I cloned from master a few hours ago and the issue was present. Some more people have it as well on OS X. |
|
The issue is that while pkg-config is used to determine if the libraries are there, it only uses the linking information, not the include directories. We just need to add those. I'm working on a patch now. |
|
The crate |
|
I'm gonna need to take a look (it should return all tracks). |
|
@GuillaumeGomez my ogg metadata crate should return all tracks it can find. If that doesn't work or its not enough, please say so! |
|
I think the error comes from |
|
IIUC this was fixed with the addition of servo-media. Please, reopen if you consider that this issue is still valid. |
An integration can be made here with the video-metadata-rs crate.
However, like said in the README,
video-metadata-rsis using the version 3.x of FFMPEG libraries. So the libs have to be built and installed manually (well, I guess it's not really an issue but I prefer to make a note about it). I think it could get downgraded to 2.x version quite easily but I think it's better to use lastest version.I think I resumed all information about it. If you think I forgot something, please tell me!😃
I'll start to work on it in the next days.
cc @jdm