Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending work for transitions/animations #11916

Closed
emilio opened this issue Jun 28, 2016 · 4 comments
Closed

Pending work for transitions/animations #11916

emilio opened this issue Jun 28, 2016 · 4 comments
Assignees

Comments

@emilio
Copy link
Member

@emilio emilio commented Jun 28, 2016

Assuming #11766 lands, this would be the pending work left to do for animations and transitions. I'm planning in doing it, though if someone wants to help that would be appreciated.
Pending work for animations/transitions:

  • Support more animated properties: These are marked with a FIXME in
    style/properties/longhands/. These are easy, it's just a matter of
    following the transitions spec and implement the interpolation
    appropriately.
  • Support the animation shorthand. This should be easy.
  • Scan for all the animatable properties of all the keyframes, not just the
    first one. This is not specified, but all other browsers seem to do this.
  • Apply all the previous keyframes' declarations when computed the style. We
    only apply the previous keyframe, and interpolate it with the target one.
    We should do all the chain, maybe storing the current animation's computed
    style in the state to be a bit more efficient? We should be able to do that
    while the animation is ticking, but not on style because we don't have
    write access to the hashmap (well, we could, but it could become really
    slow).
  • Don't remove animations from the layout hashmap when they get expired. This
    might cause them to get retriggered on the next restyle, which is wrong.
  • Implement animation-fill-mode. This will allow us to test the animation
    code.
  • Fix the parsing of the steps() function, which was wrong.
  • Figure out how to test all this stuff (#12120).
  • Split the SharedLayoutContext in two different pieces, one cloneable per
    thread, and one inmutable as it's today. This will allow us to take rid of
    the Mutex in new_animations_sender.
  • File a spec bug about why Gecko doesn't seem to parse
    @keyframes "bar" {}, or fix it in gecko directly.
  • Probably a few more things.
@emilio emilio self-assigned this Jun 28, 2016
@emilio
Copy link
Member Author

@emilio emilio commented Jun 28, 2016

@emilio
Copy link
Member Author

@emilio emilio commented Jun 30, 2016

@SimonSapin: The string part for the animation name seems to have been added lately, so it's just no-one else has implemented it yet :)

bors-servo added a commit that referenced this issue Jul 7, 2016
style: Add support to the animation shorthand and fix parsing of animation-name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Part of #11916.

r? @SimonSapin

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 7, 2016
style: Add support to the animation shorthand and fix parsing of animation-name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Part of #11916.

r? @SimonSapin

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 8, 2016
style: Add support to the animation shorthand and fix parsing of animation-name

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Part of #11916.

r? @SimonSapin

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118)
<!-- Reviewable:end -->
@mrobinson
Copy link
Member

@mrobinson mrobinson commented May 14, 2020

@emilio Can you confirm whether or not parsing of steps() has been fixed? I think if it has, we can close this issue in favor of #26328.

@emilio
Copy link
Member Author

@emilio emilio commented May 14, 2020

Yeah, I believe steps parsing should be fine now. Seems fine to close as a dupe. Thanks!

@emilio emilio closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.