Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPending work for transitions/animations #11916
Closed
Labels
Comments
|
cc @SimonSapin |
|
@SimonSapin: The string part for the animation name seems to have been added lately, so it's just no-one else has implemented it yet :) |
bors-servo
added a commit
that referenced
this issue
Jul 7, 2016
style: Add support to the animation shorthand and fix parsing of animation-name <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Part of #11916. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 7, 2016
style: Add support to the animation shorthand and fix parsing of animation-name <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Part of #11916. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 8, 2016
style: Add support to the animation shorthand and fix parsing of animation-name <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Part of #11916. r? @SimonSapin <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12118) <!-- Reviewable:end -->
|
Yeah, I believe steps parsing should be fine now. Seems fine to close as a dupe. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assuming #11766 lands, this would be the pending work left to do for animations and transitions. I'm planning in doing it, though if someone wants to help that would be appreciated.
Pending work for animations/transitions:
style/properties/longhands/. These are easy, it's just a matter offollowing the transitions spec and implement the interpolation
appropriately.
animationshorthand. This should be easy.first one. This is not specified, but all other browsers seem to do this.
only apply the previous keyframe, and interpolate it with the target one.
We should do all the chain, maybe storing the current animation's computed
style in the state to be a bit more efficient? We should be able to do that
while the animation is ticking, but not on style because we don't have
write access to the hashmap (well, we could, but it could become really
slow).
might cause them to get retriggered on the next restyle, which is wrong.
code.
steps()function, which was wrong.thread, and one inmutable as it's today. This will allow us to take rid of
the Mutex in
new_animations_sender.@keyframes "bar" {}, or fix it in gecko directly.