Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new "armv7-android-linuxeabi" target triple #11921

Closed
mbrubeck opened this Issue Jun 29, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 29, 2016

rust-lang/rust#33278 added a new Android target, armv7-android-linuxeabi.

In the near future, the existing arm-android-linuxeabi target (which Servo uses by default when building for Android) will be changed to use the ARMv5TE instruction set instead of ARMv7. We will need to switch to the new target if we want to continue generating ARMv7 code (and linking to standard libraries built for ARMv7).

This will require finding and fixing any packages whose build scripts that assume the $TARGET used by Cargo and rustc is the same as the $TARGET needed for the C toolchain, for example harfbuzz-sys and probably most of our other crates that can build their own C libraries.

@aneeshusa

This comment has been minimized.

Copy link
Member

aneeshusa commented Jun 29, 2016

cc me, need to see how this affects servo/saltfs#355 and ARM triple naming

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

larsbergstrom commented May 3, 2017

This has become newly important, as Rust just landed:
rust-lang/rust#41656

I'd expect that to significantly regress Android performance unless we switch to the new target.

cc @fabricedesre @MortimerGoro

@MortimerGoro

This comment has been minimized.

Copy link
Contributor

MortimerGoro commented May 3, 2017

I have some wip code in Servo python scripts to add armv7 and aarch64 target compilation parameters. The biggest blocker are some makefile based crates/dependencies which fail to compile

An easier way to fix this may be using make-standalone-toolchain.sh script to generate a preconfigured ndk toolchain. At least, with some tests I did, preconfigured NDKs worked almost on first try, while using the full ndk with CXX params produced tons of errors.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor

larsbergstrom commented May 3, 2017

My only worry about that is that we used to use make-standalone-toolchain.sh, but when we had to move to the LLVM C++ stdlib (due to Gecko native dep requirements, especially SM), the script did not properly create a standalone toolchain across ~5 different releases of the NDK that I tried.

It was also a huge failure point for people building for Android. They'd forget to do it or not do it quite right or not get the two env variables correct (you have to install the SDK and NDK and set env vars to the SDK and the made toolchain).

I'd loop with @froydnj, who I believe pointed me at the original gecko code that I cribbed for picking up the right NDK folders. I think it's all here:
https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4#91

@MortimerGoro

This comment has been minimized.

Copy link
Contributor

MortimerGoro commented May 8, 2017

@larsbergstrom Yes, I agree that standalone toolchains add more complexity to the users. It's better if we assume the complexity and make users happier ;)

I pushed #16769 for armv7 and aarch64 target triples support in python build scripts (build + packaging).

arm-linux-androideabi is still the default, we can change it when all armv7 compilation errors are fixed in dependencies.

We still need to fix the crates failing to compile form arm-v7 and aarch64.

I fixed armv7 and aarch64 compilation for mozjs in this PR:
servo/mozjs#118

Mio libray fails to compile in aarch64, but a PR is already in progress: carllerche/mio#599

Other libraries found that still needs to be fixed: libfontconfig, skia.

bors-servo added a commit to servo/mozjs that referenced this issue May 8, 2017

Auto merge of #118 - MortimerGoro:android_archs, r=jdm
Support for Android armv7 and aarch64 target triples

See servo/servo#11921 and servo/servo#16769

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/118)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this issue May 13, 2017

Auto merge of #16769 - MortimerGoro:android_archs, r=larsbergstrom
Support for Android armv7 and aarch64 target triples

<!-- Please describe your changes on the following line: -->

Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging)

`--android` build parameter works as always (arm-linux-androideabi still the default)
`./mach build --release --android`

New compilation modes for android
`./mach build --release --target=arm-linux-androideabi`
`./mach build --release --target=armv7-linux-androideabi`
`./mach build --release --target=aarch64-linux-android`

See #11921. When all crates are ready we'll switch default android compilations to` armv7-linux-androideabi` target triple.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16769)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 14, 2017

servo: Merge #16769 - Support for Android armv7 and aarch64 target tr…
…iples (from MortimerGoro:android_archs); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging)

`--android` build parameter works as always (arm-linux-androideabi still the default)
`./mach build --release --android`

New compilation modes for android
`./mach build --release --target=arm-linux-androideabi`
`./mach build --release --target=armv7-linux-androideabi`
`./mach build --release --target=aarch64-linux-android`

See servo/servo#11921. When all crates are ready we'll switch default android compilations to` armv7-linux-androideabi` target triple.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 286bfb96a06705e37e690be07a51f5e1797f35b0

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 5e578d7a8b567da6913e8ba63720d6a877b20ca1

bors-servo added a commit that referenced this issue May 15, 2017

Auto merge of #16866 - MortimerGoro:update_mozjs, r=nox
Update mozjs_sys

<!-- Please describe your changes on the following line: -->

See servo/mozjs#118

Required for #11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16866)
<!-- Reviewable:end -->

bors-servo added a commit to servo/rust-harfbuzz that referenced this issue May 15, 2017

Auto merge of #71 - MortimerGoro:armv7_android, r=jdm
Fix armv7-linux-androideabi compilation

Required for servo/servo#11921

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-harfbuzz/71)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 16, 2017

servo: Merge #16866 - Update mozjs_sys (from MortimerGoro:update_mozj…
…s); r=nox

<!-- Please describe your changes on the following line: -->

See servo/mozjs#118

Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9bc565362b8787768db77ac458c9fb8005e14023

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 051657136a772c64ba7b67a8b418ac7bebcbec5e

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue May 16, 2017

servo: Merge #16769 - Support for Android armv7 and aarch64 target tr…
…iples (from MortimerGoro:android_archs); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging)

`--android` build parameter works as always (arm-linux-androideabi still the default)
`./mach build --release --android`

New compilation modes for android
`./mach build --release --target=arm-linux-androideabi`
`./mach build --release --target=armv7-linux-androideabi`
`./mach build --release --target=aarch64-linux-android`

See servo/servo#11921. When all crates are ready we'll switch default android compilations to` armv7-linux-androideabi` target triple.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 286bfb96a06705e37e690be07a51f5e1797f35b0

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue May 16, 2017

servo: Merge #16866 - Update mozjs_sys (from MortimerGoro:update_mozj…
…s); r=nox

<!-- Please describe your changes on the following line: -->

See servo/mozjs#118

Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9bc565362b8787768db77ac458c9fb8005e14023

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue May 17, 2017

servo: Merge #16769 - Support for Android armv7 and aarch64 target tr…
…iples (from MortimerGoro:android_archs); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

Support for Android armv7 and aarch64 target triples in python build scripts (build + packaging)

`--android` build parameter works as always (arm-linux-androideabi still the default)
`./mach build --release --android`

New compilation modes for android
`./mach build --release --target=arm-linux-androideabi`
`./mach build --release --target=armv7-linux-androideabi`
`./mach build --release --target=aarch64-linux-android`

See servo/servo#11921. When all crates are ready we'll switch default android compilations to` armv7-linux-androideabi` target triple.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 286bfb96a06705e37e690be07a51f5e1797f35b0

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue May 17, 2017

servo: Merge #16866 - Update mozjs_sys (from MortimerGoro:update_mozj…
…s); r=nox

<!-- Please describe your changes on the following line: -->

See servo/mozjs#118

Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 9bc565362b8787768db77ac458c9fb8005e14023

bors-servo added a commit to servo/libfontconfig that referenced this issue May 19, 2017

Auto merge of #29 - MortimerGoro:android_archs, r=mbrubeck
Add support for Android armv7 and aarch64 compilations.

See servo/servo#11921

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/libfontconfig/29)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this issue May 19, 2017

Auto merge of #16905 - MortimerGoro:update_harfbuzz, r=jdm
Update harfbuzz-sys

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/rust-harfbuzz/pull/71/files. Required for #11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16905)
<!-- Reviewable:end -->

@MortimerGoro MortimerGoro referenced this issue May 19, 2017

Merged

Update libfontconfig #16957

3 of 5 tasks complete

bors-servo added a commit that referenced this issue May 21, 2017

Auto merge of #16957 - MortimerGoro:update_libfontconfig, r=jdm
Update libfontconfig

<!-- Please describe your changes on the following line: -->

See servo/libfontconfig#29. Required for #11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16957)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this issue May 21, 2017

Auto merge of #16957 - MortimerGoro:update_libfontconfig, r=jdm
Update libfontconfig

<!-- Please describe your changes on the following line: -->

See servo/libfontconfig#29. Required for #11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16957)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this issue May 21, 2017

Auto merge of #16905 - MortimerGoro:update_harfbuzz, r=jdm
Update harfbuzz-sys

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/rust-harfbuzz/pull/71/files. Required for #11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16905)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 22, 2017

servo: Merge #16905 - Update harfbuzz-sys (from MortimerGoro:update_h…
…arfbuzz); r=jdm

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/rust-harfbuzz/pull/71/files. Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: eabbee629104076c1a776a31bf0fd0b5b802964f

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 6c1fb4ad19e3dc9d461571bdadf088b053880b93

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue May 22, 2017

servo: Merge #16905 - Update harfbuzz-sys (from MortimerGoro:update_h…
…arfbuzz); r=jdm

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/rust-harfbuzz/pull/71/files. Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: eabbee629104076c1a776a31bf0fd0b5b802964f

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue May 25, 2017

servo: Merge #16905 - Update harfbuzz-sys (from MortimerGoro:update_h…
…arfbuzz); r=jdm

<!-- Please describe your changes on the following line: -->

See https://github.com/servo/rust-harfbuzz/pull/71/files. Required for servo/servo#11921

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: eabbee629104076c1a776a31bf0fd0b5b802964f

@MortimerGoro MortimerGoro referenced this issue May 30, 2017

Merged

Support for Android arm64 compilations #17099

3 of 4 tasks complete

bors-servo added a commit that referenced this issue May 31, 2017

Auto merge of #17008 - MortimerGoro:android_default_armv7, r=larsberg
Make armv7-linux-androideabi default target on Android

<!-- Please describe your changes on the following line: -->

See #11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17008)
<!-- Reviewable:end -->

bors-servo added a commit that referenced this issue May 31, 2017

Auto merge of #17008 - MortimerGoro:android_default_armv7, r=larsberg
Make armv7-linux-androideabi default target on Android

<!-- Please describe your changes on the following line: -->

See #11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17008)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 1, 2017

servo: Merge #17008 - Make armv7-linux-androideabi default target on …
…Android (from MortimerGoro:android_default_armv7); r=larsberg

<!-- Please describe your changes on the following line: -->

See servo/servo#11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a694f70acf2f011da816a24716d6501ab153c64e

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : aac3cdcf833b6cd64b5f81d27ae213d7272fe08d

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue Jun 2, 2017

servo: Merge #17008 - Make armv7-linux-androideabi default target on …
…Android (from MortimerGoro:android_default_armv7); r=larsberg

<!-- Please describe your changes on the following line: -->

See servo/servo#11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a694f70acf2f011da816a24716d6501ab153c64e

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue Jun 5, 2017

servo: Merge #17008 - Make armv7-linux-androideabi default target on …
…Android (from MortimerGoro:android_default_armv7); r=larsberg

<!-- Please describe your changes on the following line: -->

See servo/servo#11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a694f70acf2f011da816a24716d6501ab153c64e

Manishearth pushed a commit to Manishearth/gecko-dev that referenced this issue Jun 11, 2017

servo: Merge #17008 - Make armv7-linux-androideabi default target on …
…Android (from MortimerGoro:android_default_armv7); r=larsberg

<!-- Please describe your changes on the following line: -->

See servo/servo#11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a694f70acf2f011da816a24716d6501ab153c64e

bors-servo added a commit that referenced this issue Jul 8, 2017

Auto merge of #17099 - MortimerGoro:android_arm64, r=larsbergstrom
Support for Android arm64 compilations

<!-- Please describe your changes on the following line: -->

This PR is the final step to adds support for Android arm64 compilations. See #11921 for previous work.

Fixes in this PR:
- Fix js dependency compilation: servo/rust-mozjs#360
- Fix skia dependency link error: servo/skia#136
- Fix blurdroid dependency compilation: szeged/blurdroid#4
- Fix mio and net2 dependency compilations: carllerche/mio#599
- Fix gcc compiler name in the fake linker
- Compile OpenSSL for aarch64 (update to stable 1.1.0 was required for this)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17099)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 9, 2017

servo: Merge #17099 - Support for Android arm64 compilations (from Mo…
…rtimerGoro:android_arm64); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

This PR is the final step to adds support for Android arm64 compilations. See servo/servo#11921 for previous work.

Fixes in this PR:
- Fix js dependency compilation: servo/rust-mozjs#360
- Fix skia dependency link error: servo/skia#136
- Fix blurdroid dependency compilation: szeged/blurdroid#4
- Fix mio and net2 dependency compilations: carllerche/mio#599
- Fix gcc compiler name in the fake linker
- Compile OpenSSL for aarch64 (update to stable 1.1.0 was required for this)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 85e5551ee9f2f662bdca53469a327491f35ece53

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f70197e8d6f16df92040706a0e3473d66266f373

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue Jul 10, 2017

servo: Merge #17099 - Support for Android arm64 compilations (from Mo…
…rtimerGoro:android_arm64); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

This PR is the final step to adds support for Android arm64 compilations. See servo/servo#11921 for previous work.

Fixes in this PR:
- Fix js dependency compilation: servo/rust-mozjs#360
- Fix skia dependency link error: servo/skia#136
- Fix blurdroid dependency compilation: szeged/blurdroid#4
- Fix mio and net2 dependency compilations: carllerche/mio#599
- Fix gcc compiler name in the fake linker
- Compile OpenSSL for aarch64 (update to stable 1.1.0 was required for this)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 85e5551ee9f2f662bdca53469a327491f35ece53

Manishearth pushed a commit to Manishearth/gecko-dev that referenced this issue Jul 10, 2017

servo: Merge #17099 - Support for Android arm64 compilations (from Mo…
…rtimerGoro:android_arm64); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

This PR is the final step to adds support for Android arm64 compilations. See servo/servo#11921 for previous work.

Fixes in this PR:
- Fix js dependency compilation: servo/rust-mozjs#360
- Fix skia dependency link error: servo/skia#136
- Fix blurdroid dependency compilation: szeged/blurdroid#4
- Fix mio and net2 dependency compilations: carllerche/mio#599
- Fix gcc compiler name in the fake linker
- Compile OpenSSL for aarch64 (update to stable 1.1.0 was required for this)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 85e5551ee9f2f662bdca53469a327491f35ece53

brendandahl pushed a commit to brendandahl/gecko that referenced this issue Jul 10, 2017

servo: Merge #17008 - Make armv7-linux-androideabi default target on …
…Android (from MortimerGoro:android_default_armv7); r=larsberg

<!-- Please describe your changes on the following line: -->

See servo/servo#11921

After fixing problematic dependencies this is the last step to support armv7-linux-androideabi target on Android:

- Updates skia dependency to fix a linker error. See servo/skia#136
- Fixes specifying android targets on `./mach package` and `./mach install` steps:
  -`./mach package --release --target=arm-linux-androideabi`
  -`./mach package --release --target=armv7-linux-androideabi`
  -`./mach package --release --target=aarch64-linux-android`
- Make `armv7-linux-androideabi`default when `--android` param is used in build, package or install commands

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11921 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: a694f70acf2f011da816a24716d6501ab153c64e

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue Jul 11, 2017

servo: Merge #17099 - Support for Android arm64 compilations (from Mo…
…rtimerGoro:android_arm64); r=larsbergstrom

<!-- Please describe your changes on the following line: -->

This PR is the final step to adds support for Android arm64 compilations. See servo/servo#11921 for previous work.

Fixes in this PR:
- Fix js dependency compilation: servo/rust-mozjs#360
- Fix skia dependency link error: servo/skia#136
- Fix blurdroid dependency compilation: szeged/blurdroid#4
- Fix mio and net2 dependency compilations: carllerche/mio#599
- Fix gcc compiler name in the fake linker
- Compile OpenSSL for aarch64 (update to stable 1.1.0 was required for this)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 85e5551ee9f2f662bdca53469a327491f35ece53

@MortimerGoro MortimerGoro referenced this issue Sep 5, 2017

Open

Apple iOS support #18154

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.