Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMenu demo: items are deleted when selected #11941
Comments
|
Adding P1 as I assume we want all the linked demos on the newtab page to work properly. Feel free to change it if it shouldn't be P1. |
|
Unsurprisingly, but just to confirm - this occurs both with and without WR enabled. |
|
A minimal example which demonstrates this behaviour: <!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Minimal example for #11941</title>
<style>
ul li {
color: #92a5bf;
background-color: #f5f8fe;
transition: linear 0.2s all;
}
ul.active li {
background-color: red;
}
</style>
</head>
<body>
<ul>
<li>
<input id='website' name='type' type='radio'>
<label for='website'>Website</label>
</li>
<li>
<input id='icon' name='type' type='radio'>
<label for='icon'>Icon</label>
</li>
<li>
<input id='mobile' name='type' type='radio'>
<label for='mobile'>Mobile</label>
</li>
</ul>
</body>
<script>
window.onload = function() {
document.getElementsByTagName("ul")[0].setAttribute("class","active");
};
</script>
</html> |
|
OK, this is just weird: <!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>Minimal example for #11941</title>
<style>
ul.active li.unselected {
color: red;
transition: linear 0.2s all;
}
ul.active li.selected {
color: blue;
transition: linear 0.2s all;
}
</style>
</head>
<body>
<ul>
<li class="unselected">
<input id='website' name='type' type='radio'>
<label for='website'>Website</label>
</li>
<li>
<input id='icon' name='type' type='radio'>
<label for='icon'>Icon</label>
</li>
<li>
<input id='mobile' name='type' type='radio'>
<label for='mobile'>Mobile</label>
</li>
</ul>
</body>
<script>
window.onload = function() {
document.getElementsByTagName("ul")[0].setAttribute("class","active");
var lis = document.getElementsByTagName("li");
var selection = null;
for (var i=0; i<lis.length; i++) {
lis[i].setAttribute("class","unselected");
lis[i].onclick = function() {
if (selection) { selection.setAttribute("class","unselected"); }
selection = this;
this.setAttribute("class","selected");
}
}
};
</script>
</html>The bullet on the li ends up a different color than its text! |
|
Definitely an incremental layout bug; can’t reproduce it when running with |
|
For me, the 2nd example is weird even with |
|
IRC chat: http://logs.glob.uno/?c=mozilla%23servo&s=30+Jun+2016&e=30+Jun+2016#c467566 TL;DR: @metajack says "can you rpelace it with spinner?". |
|
If this isn't on the splash page, fixing it isn't P1. |
|
I wonder if this is the same error as on mozilla.org/en-US/. Mousing over any of the tiles removes them permanently. |
|
Could be, it's caused by css transitions not leaving things in the right state. I can believe mozilla.org is using transitions the same way. |
|
Test case from #11941 (comment) still behaves weirdly. |
This is a demo on the
about:newtabon bhtml.The checkbox to the left of the item should be checked rather than the item being deleted.