Browser.html icons look pixelated

[fabricedesre]

See http://imgur.com/Bf7THC0 : screenshot from a linux debug build, on ubuntu 16.04.

[Coder206]

This is also the case for Windows 10.

[paulrouget]

non-hidpi display?

[metajack]

@Coder206 what do you mean? which icons? I definitely added high dpi support to Windows, and it hasn't regressed that I've seen.

[Coder206]

@paulrouget @metajack

[fabricedesre]

non-hidpi display?

Yep. Good old thinkpad 1366x768 pixels at 96dpi.

[Coder206]

@metajack How can I tell that I have hidipi on Windows?

[cbrewster]

Is this on a debug or release build. I noticed the images looked blurry on debug, but fine on release.

[Coder206]

@ConnorGBrewster For me (^): release.

[fabricedesre]

Is this on a debug or release build. I noticed the images looked blurry on debug, but fine on release.

Same on release & debug for me.

[cbrewster]

I have noticed that non-wr causes these icons to look pixelated. WR is not enabled by default on Windows, correct?

[jdm]

WR is not default anywhere yet.

[cbrewster]

@jdm I mean -b implies -w except on Windows.

Edit: now that I look, it looks like -w is also passed when using -b on Windows.

[jdm]

No, -w is used on all platforms: https://dxr.mozilla.org/servo/rev/c4aaedab32eb906ff715b850b641d2a75536e73d/python/servo/post_build_commands.py#114

[atouchet]

It looks like there may be some image scaling issues going on. I made a comparison picture of Servo vs. Firefox rendering the home screen (Firefox is the top result and Servo is the bottom):

There are some pretty noticeable aliasing and legibility problems with the Servo example.

[metajack]

cc @jonathandturner

[jonathandturner]

@atouchet - what hardware/OS are you running? I've noticed different things with different video cards

[atouchet]

@jonathandturner Windows 10 with Nvidia GeForce GTX 580.

[jonathandturner]

Now that I have my laptop back, I can repro this. Seems like it's particular to certain video cards/resolutions.

[atouchet]

I tried re-testing this with a Nvidia GeForce GTX 1050 Ti and I am still getting the same issue. For what it's worth I am also using a 1080p monitor.

[atouchet]

Looking at this more I am fairly sure that it's an image scaling issue with Servo. I noticed that the Moiré demo tile appears noticeably different in Servo and Firefox when they both load the Browser.html homepage. So I tried independently scaling the original 800 x 500 tile using bicubic, bilinear, and nearest neighbour scaling to 160 x 100 to match the Browser.html homescreen.

Results:

And here is the Browser.html homescreen (Firefox top, Servo bottom):

Firefox looks to be using bicubic or bilinear scaling while Servo looks to be using nearest neighbour which explains why the tiles look more pixelated.