Create new folder when packaging on linux

[cbrewster]

Right now we take the target/[relase|debug] and remove everything but servo and bhtml and when we copy resources and add the run script. We should instead create a new temporary folder, copy servo, bhtml, resources, runscript to the new directory and create the tar.gz from that. After the tar.gz is created, the temporary folder should be deleted. This is similar to how packaging is done on the mac. The script should also check for the temporary folder when starting the packaging and delete it if it exists. If you don't do this, there will be errors with copying since shutil.copytree will not overwrite existing.

[highfive]

Please make a comment here if you intend to work on this issue. Thank you!

[Coder206]

@ConnorGBrewster I would like to try solving this issue.

[aneeshusa]

It would be nice to do some locking of the packaging directory to prevent simultaneous builds, but I would not consider part of the E-easy (can be done in a follow-up).

[Coder206]

Not sure where to start. Would I be able to use Rust to write the code and implement @ConnorGBrewster's issue?

[cbrewster]

@Coder206 the packaging script is in python/servo/package_commands.py, if you look there there are android, OS X, and other branches for packaging. The other branch (which will be used for only linux in the future) currently makes changes to the [debug|release] folders when making the package. I would rather create a new directory and copy the needed files to the new directory than altering the [debug|release] folders. You can look at the mac branch as an example as it creates a new directory called dmg and copies the needed files to their respective locations there.

[highfive]

cc @wafflespeanut

[Coder206]

@ConnorGBrewster Ok perfect. That makes sense! Thanks :)

[cbrewster]

@Coder206 any progress on this?

[Coder206]

@ConnorGBrewster Yes, I was beginning to understand how everything works. However, it will be at least a week before a PR is submitted. I understand if you want to give this to someone else to get it done quicker.

[cbrewster]

@Coder206 no worries, this isn't a huge priority right now.

[Coder206]

@ConnorGBrewster I made modification to python/servo/package_commands.py that reflect what you asked above based on OSX's code. I had a few questions:

1. When you say copy "servo", should the script copy the whole directory?
2. To test my code to make sure it works, is python package_commands.py the way to do that?

[jdm]

Copy servo means copy the servo binary.

[jdm]

I'm pretty sure the correct way to test it is ./mach package.

[Coder206]

@jdm Thanks