Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upYoutube causes a panic #11992
Closed
Youtube causes a panic #11992
Labels
Comments
|
Looks like the panic is on parsing the punycode URL |
|
servo/rust-url#207 is the parse error. We shouldn't be crashing in the image load anyway. |
bors-servo
added a commit
that referenced
this issue
Jul 1, 2016
Don't crash when <img> fails to parse its src Fixes #11992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12003) <!-- Reviewable:end -->
This was referenced Jul 1, 2016
bors-servo
added a commit
that referenced
this issue
Jul 1, 2016
Don't crash when <img> fails to parse its src Fixes #11992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12003) <!-- Reviewable:end -->
This was referenced Jul 1, 2016
bors-servo
added a commit
that referenced
this issue
Jul 5, 2016
Don't crash when <img> fails to parse its src Fixes #11992 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12003) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not that youtube should be working anyway, but we shouldn't be panicking there