Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub login page not rendered properly #12092

Closed
nickpsecurity opened this issue Jul 1, 2016 · 4 comments
Closed

GitHub login page not rendered properly #12092

nickpsecurity opened this issue Jul 1, 2016 · 4 comments
Labels
A-layout/uncategorized A-webcompat C-needs-test I-wrong

Comments

@nickpsecurity
Copy link

@nickpsecurity nickpsecurity commented Jul 1, 2016

github screenshot forgot password

Renders "forgot password" link in a weird way. Ubuntu 16.04 bare-metal running pre-packaged binary of Servo.
@Aaron1011
Copy link
Contributor

@Aaron1011 Aaron1011 commented Jul 1, 2016

I'd like to work on this.
@cbrewster cbrewster added the C-assigned label Jul 1, 2016
@Aaron1011
Copy link
Contributor

@Aaron1011 Aaron1011 commented Jul 1, 2016 •
edited

I believe I've narrowed the issue down to this:

<!DOCTYPE html>
<html>
<body>

<p>Password <a style="float: right;">Forgot password?</a></p>
<input style="width: 100%;" />

</body></html>

Here's what it looks like in Firefox 47:

Firefox

And here's the latest Servo:

Server

From what I can tell, the root issue appears to be the large vertical gap that appears between the <p> and <a> elements which shoot be aligned vertically.

EDIT - Firefox gives almost the same behavior when swapping the <a> element for another <p> element. Could this be an issue with the default styling in Servo?

EDIT 2 - The previous issue may have something to do with Phrasing content - <p> elements are not phrasing content, while <a> elements are.
@KiChjang
Copy link
Member

@KiChjang KiChjang commented Oct 12, 2016

Unassigning due to inactivity for over 3 months.
@KiChjang KiChjang removed the C-assigned label Oct 12, 2016
@stshine
Copy link
Contributor

@stshine stshine commented May 5, 2017

Duplicate of #13683.
@stshine stshine closed this May 5, 2017
@pcwalton pcwalton mentioned this issue Mar 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized A-webcompat C-needs-test I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@mbrubeck @Aaron1011 @stshine @KiChjang @cbrewster @nickpsecurity
You can’t perform that action at this time.