Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHow to test transitions/animations? #12120
Closed
Labels
Comments
|
So the idea I'm thinking about is adding a pref or something as we do to test our crash handler, but adding:
I think that should be enough to be able to write a bunch of animation tests under CC'ing @Ms2ger and @jdm just in case they have thoughts on this or maybe a better way to do it :) |
|
No better idea! |
|
|
|
A potential implementation of this lives in #12392 |
bors-servo
added a commit
that referenced
this issue
Jul 20, 2016
style: Add support to test animations programatically. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #12120 <!-- Either: --> - [x] There are tests for these changes OR <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> r? @SimonSapin for the style changes, @Ms2ger or @jdm for the dom and test changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12392) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As animation support increases, it'd be great to have some sort of testing support for it.
We can't test them deteministically right now. Gecko has a "test mode" in their refresh driver that allows them to fake the times, advance the clocks, etc. as well as an API to get the computed style for an element in a given point of time.
We don't have that infra, and though it seems like a good amount of work, I think it's worth doing.