Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more correct user agent (UA) string on ARM #12123

Open
aneeshusa opened this issue Jul 1, 2016 · 2 comments
Open

Use more correct user agent (UA) string on ARM #12123

aneeshusa opened this issue Jul 1, 2016 · 2 comments

Comments

@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Jul 1, 2016

Currently, our logic to pick an appropriate default user agent string assumes that everything that isn't x86_64 is i686. However, this no longer holds true with ARM platforms also existing. We should use better values here; I'm not sure what they would be.

Files:

  • components/util/opts.rs in the default_user_agent_string function

I don't think there are any tests we could write for this.

@nox
Copy link
Member

@nox nox commented Oct 4, 2017

Should we even do this?

Cc @jdm

@jdm jdm added the A-platform/utils label Oct 4, 2017
@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2017

Probably!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.