New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Nightly blockers #12125

Closed
larsbergstrom opened this Issue Jul 1, 2016 · 262 comments

Comments

Projects
None yet
@larsbergstrom
Contributor

larsbergstrom commented Jul 1, 2016

The below bugs are the ones that are required to at least have a first linked nightly build of Servo on Windows.

  • #11307 - Hot spinning on Windows shutdown
  • #11967 - Add Windows MSI packaging and publishing of the nigthtly build
  • #11969 - Add an icon to Windows
  • #12231 - Upload failing due to bad s3cmd invocation
  • #12523 - Windows tarball missing files
  • #13257 - Very slow to load or just white screen launched from installer
  • #13371 - implement font rendering on Windows
  • #15255 - Windows servo UI missing elements
  • #15428 - Windows nightly hangs when loading pages
  • #15698 - Windows Servo renders reddit text squished
  • #12937 - Keyboard input dropouts
@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 2, 2016

Contributor

@larsbergstrom So @waddlesplash believes #11969 should be combined with #11967 (the installer). Can you update the post above?

Contributor

Coder206 commented Jul 2, 2016

@larsbergstrom So @waddlesplash believes #11969 should be combined with #11967 (the installer). Can you update the post above?

@waddlesplash

This comment has been minimized.

Show comment
Hide comment
@waddlesplash

waddlesplash Jul 2, 2016

Yeah, it makes the most sense to do those two as one PR.

Yeah, it makes the most sense to do those two as one PR.

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 2, 2016

Contributor

Sounds good! I'll work with @metajack to merge the two PRs. I'll leave them like this for now, if you don't mind, because we don't have a separate issue for the icon & MSI packaging. I'm hoping we'll close this down very early next week.

Contributor

larsbergstrom commented Jul 2, 2016

Sounds good! I'll work with @metajack to merge the two PRs. I'll leave them like this for now, if you don't mind, because we don't have a separate issue for the icon & MSI packaging. I'm hoping we'll close this down very early next week.

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 2, 2016

Contributor

@larsbergstrom Ok, that's fine by me.

Contributor

Coder206 commented Jul 2, 2016

@larsbergstrom Ok, that's fine by me.

@perlun

This comment has been minimized.

Show comment
Hide comment
@perlun

perlun Jul 4, 2016

Contributor

@larsbergstrom - any progress thus far? (yeah, I know it's still very early in the week your TZ 😛)

Contributor

perlun commented Jul 4, 2016

@larsbergstrom - any progress thus far? (yeah, I know it's still very early in the week your TZ 😛)

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 12, 2016

Contributor

I'm going to go ahead and commit to having a working build up on Wednesday (July 20th) by hook or by crook :-)

I apologize to everybody waiting for this!

Contributor

larsbergstrom commented Jul 12, 2016

I'm going to go ahead and commit to having a working build up on Wednesday (July 20th) by hook or by crook :-)

I apologize to everybody waiting for this!

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 15, 2016

I'll be looking forward to test it and QA it!!!

I'll be looking forward to test it and QA it!!!

@thejustsoul

This comment has been minimized.

Show comment
Hide comment
@thejustsoul

thejustsoul Jul 19, 2016

Make if possible Portable mode for Windows, without any installer, and store configs\data in program folder.

Make if possible Portable mode for Windows, without any installer, and store configs\data in program folder.

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 19, 2016

Contributor

It looks like this is going to take a couple more days, but we've made really great progress. Sorry for the delay! There's... a lot to fix :-(

That said, I think that we'll have a .tar.gz containing the current Windows nightly builds in the "obvious" place tonight. We just won't have the MSI and the shutdown issue fixed for the Wednesday build.

Contributor

larsbergstrom commented Jul 19, 2016

It looks like this is going to take a couple more days, but we've made really great progress. Sorry for the delay! There's... a lot to fix :-(

That said, I think that we'll have a .tar.gz containing the current Windows nightly builds in the "obvious" place tonight. We just won't have the MSI and the shutdown issue fixed for the Wednesday build.

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 19, 2016

Contributor

@larsbergstrom I am planning on finishing up (cherry pick) with #11969 on Friday. Then, I would be happy to assist on any other issues blocking Windows.

Contributor

Coder206 commented Jul 19, 2016

@larsbergstrom I am planning on finishing up (cherry pick) with #11969 on Friday. Then, I would be happy to assist on any other issues blocking Windows.

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 19, 2016

Contributor

@Coder206 That sounds great! Once @metajack and I finish looking into & debugging the last remaining issues, the MSI will be up and we'd certainly appreciate having others look at it and help find other bugs before we announce / link it from the downloads page.

Contributor

larsbergstrom commented Jul 19, 2016

@Coder206 That sounds great! Once @metajack and I finish looking into & debugging the last remaining issues, the MSI will be up and we'd certainly appreciate having others look at it and help find other bugs before we announce / link it from the downloads page.

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 19, 2016

Contributor

@larsbergstrom OK great! Looking forward to getting back into the action!

Contributor

Coder206 commented Jul 19, 2016

@larsbergstrom OK great! Looking forward to getting back into the action!

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 19, 2016

Contributor

@larsbergstrom @metajack Happy debugging! :-)

Contributor

Coder206 commented Jul 19, 2016

@larsbergstrom @metajack Happy debugging! :-)

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 20, 2016

Contributor

Well, we finally got the upload step working and have published something... but it's missing servo.exe, so not particularly useful :-/

I'll work on fixing it ASAP, and the following link should have something more useful tomorrow:
https://download.servo.org/nightly/windows/servo-latest.tar.gz

Contributor

larsbergstrom commented Jul 20, 2016

Well, we finally got the upload step working and have published something... but it's missing servo.exe, so not particularly useful :-/

I'll work on fixing it ASAP, and the following link should have something more useful tomorrow:
https://download.servo.org/nightly/windows/servo-latest.tar.gz

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 22, 2016

Contributor

As an update, @metajack has figured out a good solution to our font loading issues and should have some code to tack on to #12525 to have a tarball that works and does not hot spin at shutdown.

After that lands, we'll work more on getting a working MSI & manifest.

Contributor

larsbergstrom commented Jul 22, 2016

As an update, @metajack has figured out a good solution to our font loading issues and should have some code to tack on to #12525 to have a tarball that works and does not hot spin at shutdown.

After that lands, we'll work more on getting a working MSI & manifest.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 22, 2016

Thank you all so much for your hard work, I am looking very much forward to
testing the first Windows build!!!

Many thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

http://www.mozilla-hispano.org
http://twitter.com/mozilla_hispano
http://facebook.com/mozillahispano

On 22 July 2016 at 10:28, Lars Bergstrom notifications@github.com wrote:

As an update, @metajack https://github.com/metajack has figured out a
good solution to our font loading issues and should have some code to tack
on to #12525 #12525 to have a
tarball that works and does not hot spin at shutdown.

After that lands, we'll work more on getting a working MSI & manifest.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaNy9a5R47xQEHZOa0wIEfVhPgKioks5qYMWNgaJpZM4JDcUy
.

Thank you all so much for your hard work, I am looking very much forward to
testing the first Windows build!!!

Many thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

http://www.mozilla-hispano.org
http://twitter.com/mozilla_hispano
http://facebook.com/mozillahispano

On 22 July 2016 at 10:28, Lars Bergstrom notifications@github.com wrote:

As an update, @metajack https://github.com/metajack has figured out a
good solution to our font loading issues and should have some code to tack
on to #12525 #12525 to have a
tarball that works and does not hot spin at shutdown.

After that lands, we'll work more on getting a working MSI & manifest.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaNy9a5R47xQEHZOa0wIEfVhPgKioks5qYMWNgaJpZM4JDcUy
.

@BladeMight

This comment has been minimized.

Show comment
Hide comment
@BladeMight

BladeMight Jul 24, 2016

So, how all going?

So, how all going?

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

If the PR will land today, the nightly for tomorrow should include Windows!

Contributor

metajack commented Jul 27, 2016

If the PR will land today, the nightly for tomorrow should include Windows!

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

The PR has landed. The next nightly build should include a Windows package.

Contributor

metajack commented Jul 27, 2016

The PR has landed. The next nightly build should include a Windows package.

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 27, 2016

Contributor

@larsbergstrom @metajack Yay! Great work!

Contributor

Coder206 commented Jul 27, 2016

@larsbergstrom @metajack Yay! Great work!

@larsbergstrom

This comment has been minimized.

Show comment
Hide comment
@larsbergstrom

larsbergstrom Jul 27, 2016

Contributor

There is now a nightly build of Servo for Windows:
https://download.servo.org/nightly/windows/servo-latest.msi

I don't think we should announce quite yet, as:

  • Startup is pretty slow
  • We still spin one CPU at shutdown
  • Keyboard input is dropped

BUT, the basic build & publishing infra and most major blockers are gone! Feel free to play with it and start opening bugs... but please don't announce widely, as the stuff above is a bit embarrassing :-)

Contributor

larsbergstrom commented Jul 27, 2016

There is now a nightly build of Servo for Windows:
https://download.servo.org/nightly/windows/servo-latest.msi

I don't think we should announce quite yet, as:

  • Startup is pretty slow
  • We still spin one CPU at shutdown
  • Keyboard input is dropped

BUT, the basic build & publishing infra and most major blockers are gone! Feel free to play with it and start opening bugs... but please don't announce widely, as the stuff above is a bit embarrassing :-)

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

Hello,

Awesome news but I'm afraid double clicking the servo-latest.msi doesn't
work in Windows 7. If I try to install it as an addon, there's a message
saying it won't install because it may be corrupt.
I would greatly appreciate your help as I can't wait to test this!!!!

Many thanks!
Best regards,
Gabriela
http://facebook.com/mozillahispano

On 27 July 2016 at 14:42, Lars Bergstrom notifications@github.com wrote:

There is now a nightly build of Servo for Windows:
https://download.servo.org/nightly/windows/servo-latest.msi

I don't think we should announce quite yet, as:

  • Startup is pretty slow
  • We still spin one CPU at shutdown
  • Keyboard input is dropped

BUT, the basic build & publishing infra and most major blockers are gone!
Feel free to play with it and start opening bugs... but please don't
announce widely, as the stuff above is a bit embarrassing :-)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGgN7XMAQUA7B_sH2bLi1mgZHfABks5qZ5iigaJpZM4JDcUy
.

Hello,

Awesome news but I'm afraid double clicking the servo-latest.msi doesn't
work in Windows 7. If I try to install it as an addon, there's a message
saying it won't install because it may be corrupt.
I would greatly appreciate your help as I can't wait to test this!!!!

Many thanks!
Best regards,
Gabriela
http://facebook.com/mozillahispano

On 27 July 2016 at 14:42, Lars Bergstrom notifications@github.com wrote:

There is now a nightly build of Servo for Windows:
https://download.servo.org/nightly/windows/servo-latest.msi

I don't think we should announce quite yet, as:

  • Startup is pretty slow
  • We still spin one CPU at shutdown
  • Keyboard input is dropped

BUT, the basic build & publishing infra and most major blockers are gone!
Feel free to play with it and start opening bugs... but please don't
announce widely, as the stuff above is a bit embarrassing :-)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGgN7XMAQUA7B_sH2bLi1mgZHfABks5qZ5iigaJpZM4JDcUy
.

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

@gaby2300 I just downloaded it (after uninstalling the ones I made yesterday) and it installed and ran fine. Can you try downloading it again? The MD5 sum for servo-latest.msi on my machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.

Contributor

metajack commented Jul 27, 2016

@gaby2300 I just downloaded it (after uninstalling the ones I made yesterday) and it installed and ran fine. Can you try downloading it again? The MD5 sum for servo-latest.msi on my machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

@larsbergstrom Initial startup seems to be slow, but second run it seems normal. I'm not sure what it's doing on the first load that slows it down.

I could not reproduce either of the other two issues you mentioned. Can you file them with steps to reproduce?

Contributor

metajack commented Jul 27, 2016

@larsbergstrom Initial startup seems to be slow, but second run it seems normal. I'm not sure what it's doing on the first load that slows it down.

I could not reproduce either of the other two issues you mentioned. Can you file them with steps to reproduce?

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 27, 2016

Contributor

@metajack Did you get the Servo icon working in this release?

Contributor

Coder206 commented Jul 27, 2016

@metajack Did you get the Servo icon working in this release?

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

Hi Jack, thanks for answering so quickly! I would need to know how to find
the MD5 sum you mention to check it. Thanks!

On 27 Jul 2016 3:43 pm, "Jack Moffitt" notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 I just downloaded it (after
uninstalling the ones I made yesterday) and it installed and ran fine. Can
you try downloading it again? The MD5 sum for servo-latest.msi on my
machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGnO0EtWRfD6YhNEDtLk0BGrCG54ks5qZ6bTgaJpZM4JDcUy
.

Hi Jack, thanks for answering so quickly! I would need to know how to find
the MD5 sum you mention to check it. Thanks!

On 27 Jul 2016 3:43 pm, "Jack Moffitt" notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 I just downloaded it (after
uninstalling the ones I made yesterday) and it installed and ran fine. Can
you try downloading it again? The MD5 sum for servo-latest.msi on my
machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGnO0EtWRfD6YhNEDtLk0BGrCG54ks5qZ6bTgaJpZM4JDcUy
.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 27, 2016

Windows 7 64 bit Rus

Failed to create the context for the backup "C: \ Program Files \ Mozilla Research \ Servo Tech Demo \ servo.exe.Manifest". Error in manifest or policy file "C: \ Program Files \ Mozilla Research \ Servo Tech Demo \ servo.exe.Manifest" in line 9. The element "compatibility" appears as a child element "urn: schemas-microsoft-com: asm. v1 ^ assembly ", which is not supported by this version of Windows.

ghost commented Jul 27, 2016

Windows 7 64 bit Rus

Failed to create the context for the backup "C: \ Program Files \ Mozilla Research \ Servo Tech Demo \ servo.exe.Manifest". Error in manifest or policy file "C: \ Program Files \ Mozilla Research \ Servo Tech Demo \ servo.exe.Manifest" in line 9. The element "compatibility" appears as a child element "urn: schemas-microsoft-com: asm. v1 ^ assembly ", which is not supported by this version of Windows.

@kdar

This comment has been minimized.

Show comment
Hide comment
@kdar

kdar Jul 27, 2016

This is the error I get in Win 7 Pro x64:

[Window Title]
C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe

[Content]
C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe

The application has failed to start because its side-by-side configuration is incorrect. Please see the application event log or use the command-line sxstrace.exe tool for more detail.


[OK]

and the windows event log:

Activation context generation failed for "C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe.Manifest".Error in manifest or policy file "C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe.Manifest" on line 9. The element compatibility appears as a child of element urn:schemas-microsoft-com:asm.v1^assembly which is not supported by this version of Windows.

Deleting the server.exe.manifest file temporarily fixes this.

kdar commented Jul 27, 2016

This is the error I get in Win 7 Pro x64:

[Window Title]
C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe

[Content]
C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe

The application has failed to start because its side-by-side configuration is incorrect. Please see the application event log or use the command-line sxstrace.exe tool for more detail.


[OK]

and the windows event log:

Activation context generation failed for "C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe.Manifest".Error in manifest or policy file "C:\Program Files\Mozilla Research\Servo Tech Demo\servo.exe.Manifest" on line 9. The element compatibility appears as a child of element urn:schemas-microsoft-com:asm.v1^assembly which is not supported by this version of Windows.

Deleting the server.exe.manifest file temporarily fixes this.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 27, 2016

Yes, Deleting the server.exe.manifest file temporarily fixes this. it does, and the result - white screen in servo window with this picture ... no reaction from any element in window ...
srvo

ghost commented Jul 27, 2016

Yes, Deleting the server.exe.manifest file temporarily fixes this. it does, and the result - white screen in servo window with this picture ... no reaction from any element in window ...
srvo

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

Please tell me how can I delete the the server.exe.manifest then!

BTW, if I try the same as Kevin I get exactly the same result

Any idea how to fix this?

​M​
any thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

On 27 July 2016 at 16:41, rmsEfx notifications@github.com wrote:

Yes, Deleting the server.exe.manifest file temporarily fixes this. it
does, and the result - white screen in servo window with this picture ...
no reaction from any element in window ...
[image: srvo]
https://cloud.githubusercontent.com/assets/19751507/17189682/cb044916-546c-11e6-9c11-805150f304b1.jpg


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaJ6CgdaPNBuduRcg4SwHhPhl5CIeks5qZ7SCgaJpZM4JDcUy
.

Please tell me how can I delete the the server.exe.manifest then!

BTW, if I try the same as Kevin I get exactly the same result

Any idea how to fix this?

​M​
any thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

On 27 July 2016 at 16:41, rmsEfx notifications@github.com wrote:

Yes, Deleting the server.exe.manifest file temporarily fixes this. it
does, and the result - white screen in servo window with this picture ...
no reaction from any element in window ...
[image: srvo]
https://cloud.githubusercontent.com/assets/19751507/17189682/cb044916-546c-11e6-9c11-805150f304b1.jpg


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaJ6CgdaPNBuduRcg4SwHhPhl5CIeks5qZ7SCgaJpZM4JDcUy
.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

Jack, the revision number is {647E7ADC-1AE6-4405-9EDC-19C7286E888F}. Would
this be what you meant?

Saludos cordiales,
Gabriela
Responsable QA Mozilla Hispano

Un beso,
Besos,
Saludos!!
Gaby
Responsable QA Mozilla Hispano

Many thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

http://www.mozilla-hispano.org
http://twitter.com/mozilla_hispano
http://facebook.com/mozillahispano

On 27 July 2016 at 15:43, Jack Moffitt notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 I just downloaded it (after
uninstalling the ones I made yesterday) and it installed and ran fine. Can
you try downloading it again? The MD5 sum for servo-latest.msi on my
machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGnO0EtWRfD6YhNEDtLk0BGrCG54ks5qZ6bTgaJpZM4JDcUy
.

Jack, the revision number is {647E7ADC-1AE6-4405-9EDC-19C7286E888F}. Would
this be what you meant?

Saludos cordiales,
Gabriela
Responsable QA Mozilla Hispano

Un beso,
Besos,
Saludos!!
Gaby
Responsable QA Mozilla Hispano

Many thanks!
Best regards,
Gabriela
QA Mozilla Hispano Team Responsible

http://www.mozilla-hispano.org
http://twitter.com/mozilla_hispano
http://facebook.com/mozillahispano

On 27 July 2016 at 15:43, Jack Moffitt notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 I just downloaded it (after
uninstalling the ones I made yesterday) and it installed and ran fine. Can
you try downloading it again? The MD5 sum for servo-latest.msi on my
machine is b2fdc1cf82d982cf5dcc2f5e9e161b08. Please compare yours as well.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaGnO0EtWRfD6YhNEDtLk0BGrCG54ks5qZ6bTgaJpZM4JDcUy
.

@Coder206

This comment has been minimized.

Show comment
Hide comment
@Coder206

Coder206 Jul 27, 2016

Contributor

@gaby2300 Are you able to find the servo.exe.manifest file?

Contributor

Coder206 commented Jul 27, 2016

@gaby2300 Are you able to find the servo.exe.manifest file?

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

Hmm. The manifest specifically enables support for Windows 7. See https://github.com/servo/servo/blob/master/components/servo/servo.exe.manifest#L11

I'm not sure what else is required :(

Contributor

metajack commented Jul 27, 2016

Hmm. The manifest specifically enables support for Windows 7. See https://github.com/servo/servo/blob/master/components/servo/servo.exe.manifest#L11

I'm not sure what else is required :(

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Jul 27, 2016

Contributor

Ah, I think I figured this out. We are missing the correct namespace for the tag.

Contributor

metajack commented Jul 27, 2016

Ah, I think I figured this out. We are missing the correct namespace for the tag.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

@Coder206, Yes, but I cannot open it. I remember I once took out a file
from it's place to the Desktop, opened it with Note pad, erased something
and then I returned it to it's place. Do I have to do the same here and
delete server.exe.manifest?

On 27 July 2016 at 17:12, Coder206 notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 Are you able to find the
servo.exe.manifest file?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaExedQZepYENZrVjs_EvFG0oMAT7ks5qZ7u5gaJpZM4JDcUy
.

@Coder206, Yes, but I cannot open it. I remember I once took out a file
from it's place to the Desktop, opened it with Note pad, erased something
and then I returned it to it's place. Do I have to do the same here and
delete server.exe.manifest?

On 27 July 2016 at 17:12, Coder206 notifications@github.com wrote:

@gaby2300 https://github.com/gaby2300 Are you able to find the
servo.exe.manifest file?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaExedQZepYENZrVjs_EvFG0oMAT7ks5qZ7u5gaJpZM4JDcUy
.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Jul 27, 2016

I have a different id so....

On 27 July 2016 at 17:35, Jack Moffitt notifications@github.com wrote:

Hmm. The manifest specifically enables support for Windows 7. See
https://github.com/servo/servo/blob/master/components/servo/servo.exe.manifest#L11

I'm not sure what else is required :(


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaFVcDJ4IbBSeZh2ufs8YPhP3DMCtks5qZ8D1gaJpZM4JDcUy
.

I have a different id so....

On 27 July 2016 at 17:35, Jack Moffitt notifications@github.com wrote:

Hmm. The manifest specifically enables support for Windows 7. See
https://github.com/servo/servo/blob/master/components/servo/servo.exe.manifest#L11

I'm not sure what else is required :(


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12125 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACDVaFVcDJ4IbBSeZh2ufs8YPhP3DMCtks5qZ8D1gaJpZM4JDcUy
.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Mar 20, 2017

Contributor

Removing #15572 from the blockers list. I haven't been able to repro it except for isolated cases. Showcase links appear to work correctly.

Contributor

jonathandturner commented Mar 20, 2017

Removing #15572 from the blockers list. I haven't been able to repro it except for isolated cases. Showcase links appear to work correctly.

@saschanaz

This comment has been minimized.

Show comment
Hide comment
@saschanaz

saschanaz Mar 20, 2017

Please consider adding #14494 to the blockers list.

Please consider adding #14494 to the blockers list.

@metajack

This comment has been minimized.

Show comment
Hide comment
@metajack

metajack Mar 20, 2017

Contributor

@saschanaz Updated to add that.

Contributor

metajack commented Mar 20, 2017

@saschanaz Updated to add that.

@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Mar 22, 2017

Contributor

I don't know if this is concrete enough for its own issue report but I am finding that the main usability problem remaining with the Windows build now is how frequently it crashes. It's nearly impossible to browse for any significant amount of time and even some of the default showcase sites will often crash the browser.

Contributor

atouchet commented Mar 22, 2017

I don't know if this is concrete enough for its own issue report but I am finding that the main usability problem remaining with the Windows build now is how frequently it crashes. It's nearly impossible to browse for any significant amount of time and even some of the default showcase sites will often crash the browser.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Mar 22, 2017

Contributor

@atouchet - across the board there needs to be a fair bit of compatibility and stability improvements. Some of the stability issues (like the one where you scroll up and down on a webpage and it crashes after a few seconds) are not specific to the Windows build. I agree it's not particularly great right now.

That said, I'm of the mind that we need to get the Windows nightly out there so more people can try it out and jump in to help. It's still meant as a tech preview/pre-alpha release. As long as people understand we're still pre-alpha, I think it's okay to start shipping the nightly.

Contributor

jonathandturner commented Mar 22, 2017

@atouchet - across the board there needs to be a fair bit of compatibility and stability improvements. Some of the stability issues (like the one where you scroll up and down on a webpage and it crashes after a few seconds) are not specific to the Windows build. I agree it's not particularly great right now.

That said, I'm of the mind that we need to get the Windows nightly out there so more people can try it out and jump in to help. It's still meant as a tech preview/pre-alpha release. As long as people understand we're still pre-alpha, I think it's okay to start shipping the nightly.

@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Mar 22, 2017

Contributor

@jonathandturner I haven't tested the Linux or macOS versions of Servo so I don't have a frame of reference for whether certain issues are exclusive to the Windows build or are more fundamental engine issues that still need to be sorted out. I agree that shipping nightly builds for Windows would be better sooner than later.

Contributor

atouchet commented Mar 22, 2017

@jonathandturner I haven't tested the Linux or macOS versions of Servo so I don't have a frame of reference for whether certain issues are exclusive to the Windows build or are more fundamental engine issues that still need to be sorted out. I agree that shipping nightly builds for Windows would be better sooner than later.

@voracity

This comment has been minimized.

Show comment
Hide comment
@voracity

voracity Mar 26, 2017

Not sure if I should note this here: The link on the download page is broken because it says 'lastest' instead of 'latest'.

Not sure if I should note this here: The link on the download page is broken because it says 'lastest' instead of 'latest'.

@BladeMight

This comment has been minimized.

Show comment
Hide comment
@BladeMight

BladeMight Mar 26, 2017

@voracity There is already PR about this typo.

@voracity There is already PR about this typo.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Mar 30, 2017

Contributor

Still have one to go... working on it now

Contributor

jonathandturner commented Mar 30, 2017

Still have one to go... working on it now

@jonathandturner jonathandturner referenced this issue Mar 31, 2017

Merged

Fix windows glutin keydown #16198

4 of 5 tasks complete
@mzji

This comment has been minimized.

Show comment
Hide comment
@mzji

mzji Apr 9, 2017

Why does #11969 be marked as done? It's not merged yet.

mzji commented Apr 9, 2017

Why does #11969 be marked as done? It's not merged yet.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 9, 2017

Contributor

@mzji - I wonder if it got marked because the Windows build does have a logo but maybe they don't have the permanent solution in place?

Contributor

jonathandturner commented Apr 9, 2017

@mzji - I wonder if it got marked because the Windows build does have a logo but maybe they don't have the permanent solution in place?

@mzji

This comment has been minimized.

Show comment
Hide comment
@mzji

mzji Apr 9, 2017

Currently the MSI installer has an icon, but servo's executable doesn't. I think #11969 could focus on implement this (it requires windows resources, which is the main part of current #11969).

mzji commented Apr 9, 2017

Currently the MSI installer has an icon, but servo's executable doesn't. I think #11969 could focus on implement this (it requires windows resources, which is the main part of current #11969).

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 9, 2017

Contributor

@mzji - maybe I don't understand what you mean? When I open Servo, I get an icon in the dock:

servo_in_dock

Contributor

jonathandturner commented Apr 9, 2017

@mzji - maybe I don't understand what you mean? When I open Servo, I get an icon in the dock:

servo_in_dock

@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Apr 9, 2017

Contributor

@jonathandturner I have found that the Servo icon in Windows can be kind of funky. Sometimes it will load just fine, sometimes it will load but with noticeable graphical artifacts, and sometimes it just doesn't load at all.

For example here is what I am seeing with the latest nightly build:

Windows Servo Icon

Contributor

atouchet commented Apr 9, 2017

@jonathandturner I have found that the Servo icon in Windows can be kind of funky. Sometimes it will load just fine, sometimes it will load but with noticeable graphical artifacts, and sometimes it just doesn't load at all.

For example here is what I am seeing with the latest nightly build:

Windows Servo Icon

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 9, 2017

Contributor

@atouchet - if it sometimes loads and sometimes doesn't, it sounds like we have a different issue. Have you filed a bug for the behaviour you're seeing? We should probably track it down.

Contributor

jonathandturner commented Apr 9, 2017

@atouchet - if it sometimes loads and sometimes doesn't, it sounds like we have a different issue. Have you filed a bug for the behaviour you're seeing? We should probably track it down.

@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Apr 9, 2017

Contributor

@jonathandturner I haven't filed a bug yet as I wasn't sure if it was just a duplicate of #11969. If you think these are different issues I will document the problem in a bit more detail and file an issue report for it.

Also I'm not sure if you have seen it but I did file an issue for another problem with Servo on the Windows taskbar in #15942. That is kind of annoying but I'm not sure if it is big enough of an issue to be considered blocking.

Contributor

atouchet commented Apr 9, 2017

@jonathandturner I haven't filed a bug yet as I wasn't sure if it was just a duplicate of #11969. If you think these are different issues I will document the problem in a bit more detail and file an issue report for it.

Also I'm not sure if you have seen it but I did file an issue for another problem with Servo on the Windows taskbar in #15942. That is kind of annoying but I'm not sure if it is big enough of an issue to be considered blocking.

@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Apr 10, 2017

Contributor

@jonathandturner I have filed the taskbar icon issue that I ran into as #16326.

Contributor

atouchet commented Apr 10, 2017

@jonathandturner I have filed the taskbar icon issue that I ran into as #16326.

@mzji

This comment has been minimized.

Show comment
Hide comment
@mzji

mzji Apr 10, 2017

@jonathandturner What I mean is the servo main executable (servo.exe) itself doesn't have an icon. By convention windows applications embed an icon in their main executable. This is what #11969 want to do (part of). Also this might be the reason of #16326 , but that needs investigate.

mzji commented Apr 10, 2017

@jonathandturner What I mean is the servo main executable (servo.exe) itself doesn't have an icon. By convention windows applications embed an icon in their main executable. This is what #11969 want to do (part of). Also this might be the reason of #16326 , but that needs investigate.

bors-servo added a commit that referenced this issue Apr 12, 2017

Auto merge of #16198 - jonathandturner:fix_windows_gluten_keydown, r=jdm
Fix windows glutin keydown

<!-- Please describe your changes on the following line: -->
This fixes #12937 where keypresses arrive in a one-off fashion, effectively delaying each keystroke.  This PR is based heavily on @codec-abc's #16193 PR, with some further fixes and cleanup.  From the original PR comments:

> There are 2 types of events associated with keyboard: Key event (up or down) and Character Input.
>
> * A character is not necessary created one a key is pressed (like the home key).
> * A character may be created only using a combination of several key. For example, using a Qwerty International layout you have to type ` then e to get é. The first key press on ` will create no character.
> * In servo, we currently merge the 2 events together, meaning that we store a Character Input event in a field to fire a single event later on when we get a Key event.
>
> The order of events seems to be system dependent. For example, let's say that we type the A key on a Qwerty Layout. In Linux and MacOs we will get this:
>
> * Character Input for character A
> * Key down event with virtual key code of the key A
> * Key up event with virtual key code of the key A
>
> while in Windows we get:
>
> * Key down event with virtual key code of the key A
> * Character Input for character A
> * Key up event with virtual key code of the key A
>
> It seems that glutin make no attempt to reorder the event to make the order independent of the Operating System. I think it would be easier for Servo if it were handled by the library.

This fix is a stopgap for the current state of glutin.  We may want to look into a deeper fix in the future.  For now, this is hopefully adequate solution until a more permanent one can be found.

This is the last remaining issue for the Windows nightly blockers meta-issue #12125

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12937 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are around Windows keyboard eventing.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16198)
<!-- Reviewable:end -->
@atouchet

This comment has been minimized.

Show comment
Hide comment
@atouchet

atouchet Apr 12, 2017

Contributor

#12937 is now done and should be crossed off.

It's not on the list but it would be nice to have #16360 merged to fix the minimization crash issue before Windows nightlies go live. Also I don't know how important the various taskbar icon problems are but they haven't been fixed 100% yet.

Contributor

atouchet commented Apr 12, 2017

#12937 is now done and should be crossed off.

It's not on the list but it would be nice to have #16360 merged to fix the minimization crash issue before Windows nightlies go live. Also I don't know how important the various taskbar icon problems are but they haven't been fixed 100% yet.

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 12, 2017

Contributor

@atouchet - Was just about to do a build and test these all out. Since the icon issue seems to happen in release more, I'll build a release build when I test.

#16360 is now merged, so today's build is the first that could possibly become the start of the nightly. I want to get a clearer picture of how bad the icon thing is, too.

Contributor

jonathandturner commented Apr 12, 2017

@atouchet - Was just about to do a build and test these all out. Since the icon issue seems to happen in release more, I'll build a release build when I test.

#16360 is now merged, so today's build is the first that could possibly become the start of the nightly. I want to get a clearer picture of how bad the icon thing is, too.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Apr 12, 2017

I tried yet again with a build from https://download.servo.org/nightly/windows-msvc/servo-latest.msi.
I still have the same problem: a blank windows opens for a few seconds and closes.
I would greatly appreciate some help!

I tried yet again with a build from https://download.servo.org/nightly/windows-msvc/servo-latest.msi.
I still have the same problem: a blank windows opens for a few seconds and closes.
I would greatly appreciate some help!

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 12, 2017

Contributor

@gaby2300 - I don't remember if the nightly build gives a backtrace when it fails to run correctly. Can you try running it from the terminal and seeing what it outputs?

If there isn't anything there, you may need to build a debug build by hand to get the full backtrace.

At the very least, if you file an issue, we can see if we can debug what's going on.

Contributor

jonathandturner commented Apr 12, 2017

@gaby2300 - I don't remember if the nightly build gives a backtrace when it fails to run correctly. Can you try running it from the terminal and seeing what it outputs?

If there isn't anything there, you may need to build a debug build by hand to get the full backtrace.

At the very least, if you file an issue, we can see if we can debug what's going on.

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Apr 12, 2017

I tried yet again with a build from https://download.servo.org/nightly/windows-msvc/servo-latest.msi.
I still have the same problem: a blank windows opens for a few seconds and closes.
I would greatly appreciate some help!

I tried yet again with a build from https://download.servo.org/nightly/windows-msvc/servo-latest.msi.
I still have the same problem: a blank windows opens for a few seconds and closes.
I would greatly appreciate some help!

@gaby2300

This comment has been minimized.

Show comment
Hide comment
@gaby2300

gaby2300 Apr 12, 2017

@jonathandturner - I will run it from the terminal if you tell me how to do so.

I don't know how to build a debug build by hand, I'm no developer, just a very interested and long time QA tester!

File an issue in Github you mean?

@jonathandturner - I will run it from the terminal if you tell me how to do so.

I don't know how to build a debug build by hand, I'm no developer, just a very interested and long time QA tester!

File an issue in Github you mean?

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 12, 2017

Contributor

@gaby2300 - yes, please file a Github issue. That way we can track it separately rather than trying using this meta issue. You can tag me in that issue and we can see if we can figure out what's going on.

Thanks!

Contributor

jonathandturner commented Apr 12, 2017

@gaby2300 - yes, please file a Github issue. That way we can track it separately rather than trying using this meta issue. You can tag me in that issue and we can see if we can figure out what's going on.

Thanks!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 12, 2017

servo: Merge #16198 - Fix windows glutin keydown (from jonathandturne…
…r:fix_windows_gluten_keydown); r=jdm

<!-- Please describe your changes on the following line: -->
This fixes #12937 where keypresses arrive in a one-off fashion, effectively delaying each keystroke.  This PR is based heavily on @codec-abc's servo/servo#16193 PR, with some further fixes and cleanup.  From the original PR comments:

> There are 2 types of events associated with keyboard: Key event (up or down) and Character Input.
>
> * A character is not necessary created one a key is pressed (like the home key).
> * A character may be created only using a combination of several key. For example, using a Qwerty International layout you have to type ` then e to get é. The first key press on ` will create no character.
> * In servo, we currently merge the 2 events together, meaning that we store a Character Input event in a field to fire a single event later on when we get a Key event.
>
> The order of events seems to be system dependent. For example, let's say that we type the A key on a Qwerty Layout. In Linux and MacOs we will get this:
>
> * Character Input for character A
> * Key down event with virtual key code of the key A
> * Key up event with virtual key code of the key A
>
> while in Windows we get:
>
> * Key down event with virtual key code of the key A
> * Character Input for character A
> * Key up event with virtual key code of the key A
>
> It seems that glutin make no attempt to reorder the event to make the order independent of the Operating System. I think it would be easier for Servo if it were handled by the library.

This fix is a stopgap for the current state of glutin.  We may want to look into a deeper fix in the future.  For now, this is hopefully adequate solution until a more permanent one can be found.

This is the last remaining issue for the Windows nightly blockers meta-issue servo/servo#12125

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12937 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are around Windows keyboard eventing.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4c851925fbbd8446f6bfc36ff6836e9b24ad635b

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : ed025584e25c5979861919d48ddedfe656f32729

xeonchen pushed a commit to mozilla-necko/gecko that referenced this issue Apr 12, 2017

servo: Merge #16198 - Fix windows glutin keydown (from jonathandturne…
…r:fix_windows_gluten_keydown); r=jdm

<!-- Please describe your changes on the following line: -->
This fixes #12937 where keypresses arrive in a one-off fashion, effectively delaying each keystroke.  This PR is based heavily on @codec-abc's servo/servo#16193 PR, with some further fixes and cleanup.  From the original PR comments:

> There are 2 types of events associated with keyboard: Key event (up or down) and Character Input.
>
> * A character is not necessary created one a key is pressed (like the home key).
> * A character may be created only using a combination of several key. For example, using a Qwerty International layout you have to type ` then e to get é. The first key press on ` will create no character.
> * In servo, we currently merge the 2 events together, meaning that we store a Character Input event in a field to fire a single event later on when we get a Key event.
>
> The order of events seems to be system dependent. For example, let's say that we type the A key on a Qwerty Layout. In Linux and MacOs we will get this:
>
> * Character Input for character A
> * Key down event with virtual key code of the key A
> * Key up event with virtual key code of the key A
>
> while in Windows we get:
>
> * Key down event with virtual key code of the key A
> * Character Input for character A
> * Key up event with virtual key code of the key A
>
> It seems that glutin make no attempt to reorder the event to make the order independent of the Operating System. I think it would be easier for Servo if it were handled by the library.

This fix is a stopgap for the current state of glutin.  We may want to look into a deeper fix in the future.  For now, this is hopefully adequate solution until a more permanent one can be found.

This is the last remaining issue for the Windows nightly blockers meta-issue servo/servo#12125

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12937 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are around Windows keyboard eventing.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4c851925fbbd8446f6bfc36ff6836e9b24ad635b
@gaby2300

This comment has been minimized.

Show comment
Hide comment

@jonathandturner - Filed issue #16393

@jonathandturner

This comment has been minimized.

Show comment
Hide comment
@jonathandturner

jonathandturner Apr 13, 2017

Contributor

Okay, I gave the current build a test-run. There are rough edges, to be sure, but that's to be expected of a pre-alpha. Here's my thought:

I think we're ready for the Windows nightly to go live.

The showcase links work and show something coherent. Keyboard input works enough for a preview. We don't have any crashers that happen in the first few seconds of normal use.

There are a couple remaining issues, like the icon not showing up and some users experiencing the odd issue. But, I'd argue that these don't really impair the thrust of the preview, which is getting Servo into more hands and more potential contributors. That level of polish we should do, and we will continue to do, but it doesn't feel like a blocking issue for getting more people to open up the Windows nightly and try it.

Contributor

jonathandturner commented Apr 13, 2017

Okay, I gave the current build a test-run. There are rough edges, to be sure, but that's to be expected of a pre-alpha. Here's my thought:

I think we're ready for the Windows nightly to go live.

The showcase links work and show something coherent. Keyboard input works enough for a preview. We don't have any crashers that happen in the first few seconds of normal use.

There are a couple remaining issues, like the icon not showing up and some users experiencing the odd issue. But, I'd argue that these don't really impair the thrust of the preview, which is getting Servo into more hands and more potential contributors. That level of polish we should do, and we will continue to do, but it doesn't feel like a blocking issue for getting more people to open up the Windows nightly and try it.

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang

KiChjang Apr 13, 2017

Member

Since we have successfully published our Windows nightly build, I'm going to go ahead and close this issue. New issues should be created for any further problems on the Windows nightly.

Member

KiChjang commented Apr 13, 2017

Since we have successfully published our Windows nightly build, I'm going to go ahead and close this issue. New issues should be created for any further problems on the Windows nightly.

@KiChjang KiChjang closed this Apr 13, 2017

@mingwandroid

This comment has been minimized.

Show comment
Hide comment
@mingwandroid

mingwandroid Apr 13, 2017

Where can I find the mingw-w64 based build? I prefer my toolchain's source-code to be inspectable.

Where can I find the mingw-w64 based build? I prefer my toolchain's source-code to be inspectable.

Manishearth pushed a commit to Manishearth/gecko-dev that referenced this issue Apr 21, 2017

servo: Merge #16198 - Fix windows glutin keydown (from jonathandturne…
…r:fix_windows_gluten_keydown); r=jdm

<!-- Please describe your changes on the following line: -->
This fixes #12937 where keypresses arrive in a one-off fashion, effectively delaying each keystroke.  This PR is based heavily on @codec-abc's servo/servo#16193 PR, with some further fixes and cleanup.  From the original PR comments:

> There are 2 types of events associated with keyboard: Key event (up or down) and Character Input.
>
> * A character is not necessary created one a key is pressed (like the home key).
> * A character may be created only using a combination of several key. For example, using a Qwerty International layout you have to type ` then e to get é. The first key press on ` will create no character.
> * In servo, we currently merge the 2 events together, meaning that we store a Character Input event in a field to fire a single event later on when we get a Key event.
>
> The order of events seems to be system dependent. For example, let's say that we type the A key on a Qwerty Layout. In Linux and MacOs we will get this:
>
> * Character Input for character A
> * Key down event with virtual key code of the key A
> * Key up event with virtual key code of the key A
>
> while in Windows we get:
>
> * Key down event with virtual key code of the key A
> * Character Input for character A
> * Key up event with virtual key code of the key A
>
> It seems that glutin make no attempt to reorder the event to make the order independent of the Operating System. I think it would be easier for Servo if it were handled by the library.

This fix is a stopgap for the current state of glutin.  We may want to look into a deeper fix in the future.  For now, this is hopefully adequate solution until a more permanent one can be found.

This is the last remaining issue for the Windows nightly blockers meta-issue servo/servo#12125

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12937 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are around Windows keyboard eventing.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 4c851925fbbd8446f6bfc36ff6836e9b24ad635b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment