Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid does not have keyboard support #12127
Comments
|
@larsbergstrom I would like to help out with this. |
|
@Coder206 Do you mind working on easy or less easy issues for now? This issue requires you to have an android development environment set up first, and depending on your android test phone, it may not be straightfoward. I can create some easy issues if you can't find one. |
|
@KiChjang Ok, I understand. There aren't too many "easy" or "less easy" issues open right now. |
|
Since the embedder can send key events to Servo (https://doc.servo.org/compositing/windowing/enum.WindowEvent.html) would it make sense to use the other side of the embedding api to have Servo notify then embedder when an editable element is focused or blured? |
|
That seems like a sensible way to go about it. |
Notify the embedder when it should display or hide an IME <!-- Please describe your changes on the following line: --> This adds a couple of embedder messages triggered when an editable element is focused or blured. The embedder also gets the type of data to edit so it can display a different keyboard type or a custom input method eg. for color choosing. This is a partial fix for issue #12127 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach build-geckolib` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because there are no tests for the embedding api :( <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20676) <!-- Reviewable:end -->
|
@fabricedesre mentioned this earlier:
|
It's impossible to input any text in Android right now, as we don't integrate with the system keyboard.