Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake etc/ci/upload_nightly.sh responsible for putting datetimes into filenames #12128
Comments
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
Note that this needs to be fixed at most a day after we start indexing our nightlies so that we don't lose old nightlies. |
|
Happy to pick this one up also. |
|
To clarify, we no longer wish |
|
Yes, |
|
The test I mentioned will essentially require us to package (twice!), so don't worry about that for now; we need to decide about #12103 first. |
|
Resolved in: #12163 |
|
This is not yet resolved until #12163 is merged to the master branch. |
…es-12128, r=Wafflespeanut moving datetimestamping responsibilities from mach package to CI upload, swaps semicolons for dashes <!-- Please describe your changes on the following line: --> This fixes #12128 by moving the datetimestamping responsibility from the python packaging script to the CI build shell script. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12128 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because they are part of CI build <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14058) <!-- Reviewable:end -->
Part of #11980.
Currently, our Linux and Mac (although not Android)
./mach packagebuilders create files whose name include the date and time of building, which is a source of non-determinism. However, we do want to include the date and time for our nightly builds, so that multiple nightlies can coexist in a folder (e.g.$HOME/downloads) or S3 bucket (e.g.servo-builds). Two parts to this:./mach packageoutput files that always use the same name (e.g. servo.tar.gz). File:python/servo/package_commands.py.etc/ci/upload_nightly.shinsert the appropriate date and time when uploading the built nightly to S3. This depends on #12004 landing.Bonus points (but not required for the E-easy): add a test that changing the date/time (e.g. with a date/time faking library) does not affect the filename or contents of the output.