Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up./mach test-tidy doesn't ignore files underneath ignored directories #12225
Labels
Comments
1 similar comment
|
Please make a comment here if you intend to work on this issue. Thank you! |
|
Damn. I swear I'd thought about this before |
|
I'll take it! |
|
Go ahead! Feel free to ping us at the #servo channel in IRC or comment here in case you need any help :) |
|
Should I submit the PR with two commits(one for the fix and another for the test) or is a single one just fine? |
|
That's certainly up to you. We generally ask people to squash commits only if/when a future commit fixes the previous commit. |
bors-servo
added a commit
that referenced
this issue
Jul 7, 2016
test-tidy command now ignores files in subdirectories of ignored dirs <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12225 . I did not add a test for this, instead I added a directory with an empty file inside the ignored directory, and checked whether this file was being ignored or not. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12313) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 8, 2016
test-tidy command now ignores files in subdirectories of ignored dirs <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12225 . I did not add a test for this, instead I added a directory with an empty file inside the ignored directory, and checked whether this file was being ignored or not. <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12313) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a check in
get_file_listintidy.pyfor whether the given file is in a directory that is in the ignored directories list. However, this only catches things likea/b/c.pyifa/b/cis in the list - if the list containsa/b, then it doesn't get ignored as it should.To reproduce this problem, make a change to
tests/wpt/harness/wptrunner/executors/executorservo.py, sincetests/wpt/harnessis in the list of ignored directories.Code:
python/tidy/servo_tidy/tidy.pyTest:
./mach test-tidy --self-test(add a test totest_file_listinpython/tidy/servo_tidy_tests/test_tidy.py)