Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servo chokes on www.slate.com #12247

Closed
ekr opened this issue Jul 5, 2016 · 4 comments
Closed

Servo chokes on www.slate.com #12247

ekr opened this issue Jul 5, 2016 · 4 comments
Assignees
@nox
Labels
A-webcompat C-assigned C-has open PR

Comments

@ekr
Copy link

@ekr ekr commented Jul 5, 2016

The page half-loads and I see repeated complaining about:
ERROR:js::rust: Error at :0:0: QuotaExceededError: The quota has been exceeded.
@jdm
Copy link
Member

@jdm jdm commented Jul 5, 2016

Interesting; that exception is only thrown by Servo's crypto.getRandomValues() implementation.
@ekr
Copy link
Author

@ekr ekr commented Jul 5, 2016 •
edited

I haven't traced through the code, but what about?

servo/components/script/dom/storage.rs

Line 95 in e8cf789

Err(_) => Err(Error::QuotaExceeded),

@jdm: confirmed, it's coming from the above line.
@jdm
Copy link
Member

@jdm jdm commented Jul 5, 2016

Whoops, missed that in the DXR results.
@mbrubeck mbrubeck added the A-webcompat label Jul 5, 2016
@nox
Copy link
Member

@nox nox commented Jul 6, 2016 •
edited

AFAICT in StorageManager::set_item, we set current_total_size to the sum of the local and session storages' sizes, and then we use that to update the total size of the storage_type storage, accounting for the other kind of storage twice.
@nox nox added the C-assigned label Jul 6, 2016
@nox nox self-assigned this Jul 6, 2016
nox added a commit to nox/servo that referenced this issue Jul 6, 2016
@nox
Properly check storage size against QUOTA_SIZE_LIMIT (fixes servo#12247)
6638032
@nox nox added the C-has open PR label Jul 6, 2016
bors-servo added a commit that referenced this issue Jul 7, 2016
@bors-servo
Auto merge of #12289 - nox:slate, r=Ms2ger
Loading status checks…
32fa565 
Properly check storage size against QUOTA_SIZE_LIMIT (fixes #12247)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12289)
<!-- Reviewable:end -->
@bors-servo bors-servo closed this in e252793 Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-webcompat C-assigned C-has open PR
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@mbrubeck @jdm @nox @ekr
You can’t perform that action at this time.