Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent crash in /_mozilla/mozilla/htmllabel-activation.html (called `Option::unwrap()` on a `None` value) #12284

Closed
cbrewster opened this issue Jul 6, 2016 · 1 comment

Comments

@cbrewster
Copy link
Member

@cbrewster cbrewster commented Jul 6, 2016

  ▶ CRASH [expected OK] /_mozilla/mozilla/htmllabel-activation.html
  │ 
  │ ERROR:js::rust: Error at :0:0: Error: assert_unreached: disabled submit should not have been activated Reached unreachable code
  │ 
  │ ERROR:constellation::constellation: Panic: called `Option::unwrap()` on a `None` value
  │ ERROR:constellation::constellation: Backtrace:
  │ frame #0  - 0x000000010df6de2e - backtrace::backtrace::trace::hccde8df28b4db2a2
  │ frame #1  - 0x000000010df6ddb1 - backtrace::capture::Backtrace::new::h42f95930bb8c5ee8
  │ frame #2  - 0x000000010cd8d916 - _<F as alloc..boxed..FnBox<A>>::call_box::hdd90dfeb31cb8172
  │ frame #3  - 0x000000010df4c8d7 - util::panicking::initiate_panic_hook::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::ha2bd86c312dc8d7a
  │ frame #4  - 0x000000010dfc2e84 - std::panicking::rust_panic_with_hook::h983af77c1a2e581b
  │ frame #5  - 0x000000010dfdb4f6 - std::panicking::begin_panic::he426e15a3766089a
  │ frame #6  - 0x000000010dfc44c8 - std::panicking::begin_panic_fmt::hdddb415186c241e7
  │ frame #7  - 0x000000010dfdb14f - rust_begin_unwind
  │ frame #8  - 0x000000010e001fd0 - core::panicking::panic_fmt::hf4e16cb7f0d41a25
  │ frame #9  - 0x000000010e0022cc - core::panicking::panic::h907815f47e914305
  │ frame #10 - 0x000000010cb87e85 - script::dom::event::Event::new_uninitialized::hbe1c501952cb3ade
  │ frame #11 - 0x000000010cb90097 - script::dom::event::Event::new::h8264a57a7dfdfb25
  │ frame #12 - 0x000000010cbd8f7e - script::dom::eventtarget::EventTarget::fire_event::h88220d4f0eb73529
  │ frame #13 - 0x000000010ce15daa - script::task_source::dom_manipulation::DOMManipulationTask::handle_task::h3f45a410de5af916
  │ frame #14 - 0x000000010cd98c68 - script::script_thread::ScriptThread::handle_msg_from_script::h7ec8c452adacf223
  │ frame #15 - 0x000000010cdf5301 - script::script_thread::ScriptThread::handle_msgs::_$u7b$$u7b$closure$u7d$$u7d$::h3fbc4a043ad52356
  │ frame #16 - 0x000000010cddafcf - script::script_thread::ScriptThread::handle_msgs::h6a699373a020da16
  │ frame #17 - 0x000000010cd8c197 - std::panicking::try::call::h92cbb9d6dae3cd99
  │ frame #18 - 0x000000010dfde1db - __rust_try
  │ frame #19 - 0x000000010dfde175 - __rust_maybe_catch_panic
  │ frame #20 - 0x000000010cd8d344 - _<F as alloc..boxed..FnBox<A>>::call_box::h4daa47839bb6c6f7
  │ frame #21 - 0x000000010dfd9c58 - std::sys::thread::Thread::new::thread_start::h9c883b6d445ece46
  │ frame #22 - 0x00007fff88bee059 - _pthread_body
  │ frame #23 - 0x00007fff88bedfd6 - _pthread_start
  │ 
  └ ERROR:constellation::constellation: Pipeline failed in hard-fail mode.  Crashing!
@jdm jdm added the I-panic label Jul 6, 2016
bors-servo added a commit that referenced this issue Jul 6, 2016
…r=<try>

Make network listener runnable cancellable

<!-- Please describe your changes on the following line: -->
This keeps scripts from executing after its script thread has been shut down.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #12048 and fix #11703 and fix #12284 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12277)
<!-- Reviewable:end -->
@nox
Copy link
Member

@nox nox commented Aug 8, 2016

#12277 fixed this.

@nox nox closed this Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.