Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TextRunScanner to use offset+len, instead of start/end offsets #123

Closed
burg opened this issue Oct 15, 2012 · 2 comments
Closed

Convert TextRunScanner to use offset+len, instead of start/end offsets #123

burg opened this issue Oct 15, 2012 · 2 comments

Comments

@burg
Copy link

@burg burg commented Oct 15, 2012

Almost all of the layout code involving ranges is expressed using and offset plus a length. This has potential benefits for bit packing (usually offset >>>> len), and is somewhat easier to understand.

TextRunScanner is an unintended deviation.

@burg
Copy link
Author

@burg burg commented Oct 17, 2012

We should also abstract away the representation of offset, length. The bit packing decisions may be context-dependent, or change over time.

@burg
Copy link
Author

@burg burg commented Oct 17, 2012

Only TextRun::iter_natural_lines_for_range remains unconverted.

@burg burg closed this in e2c5bca Oct 18, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
remove examples as per discussion
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Support groove and ridge border styles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.