Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove util::ipc (OptionalIpcSender / OptionalOpaqueIpcSender / OpaqueSender) #12312
Comments
|
So I have the simple parts of this done. However, I ran into an issue where in |
|
You want this useful method. |
bors-servo
added a commit
that referenced
this issue
Jul 25, 2016
Remove util::ipc module (use ipc_channel instead; fixes #12312) <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12312 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because refactoring only <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12558) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Jul 26, 2016
Remove util::ipc module (use ipc_channel instead; fixes #12312) <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12312 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [X] These changes do not require tests because refactoring only <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12558) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 20, 2016
Remove util::ipc module (fixes #12312) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13831) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Oct 20, 2016
Remove util::ipc module (fixes #12312) <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13831) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This seems to be a performance optimization for the non-multiprocess case; it's not clear to me that it ever pulled its weight. Note that most of Servo uses plain
IpcSenders where these types could have been used.CC @pcwalton