Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSegfault in tinyfiledialogs causing test failures as kill races with crash dump reporter #12314
Comments
|
cc @aneeshusa |
|
I think that highstate was just intended to install |
|
Hrm, if I try to run
|
|
Here's the crash:
|
|
That's a known issue with our alert message box implementation that can be avoided via w3c/wptrunner#194. |
|
mfw Servo's roughly third segfault in the project's history is from somebody calling Thanks for tracking it down, @jdm! IT sounds like an updated version of #12223 that moves us from And on IRC, you mentioned that the tinyfiledialogs code is being updated now to remove / harden those calls. |
|
I have no idea why this suddenly started being an issue, given that the segfault-y behaviour has been present for months, but buildbot seems much happier with the change. |
|
Fixed by #12324 |
|
Thanks for figuring this out while I was at work - I'm just as shocked about Re: Salt: The only Salt changes I applied were those in servo/saltfs#428. I always |
|
@aneeshusa No worries! I certainly don't log my salt highstate runs, either, and just look through the output. Perhaps that's something we should think about, given that you, I, and @edunham all run them and may need to pick up after them? And sorry for the random accusation that it was the highstate; that seemed to be the only thing that had happened at the time that the failure rate went to nearly 100% :-) |
|
This is also where using |
|
I'd be +1 for logging all highstate runs + retention for 2 days (should be more than enough for any issues to pop up). |
@aneeshusa Do you have any logs from this update:
http://logs.glob.uno/?c=mozilla%23servo&s=6+Jul+2016&e=6+Jul+2016&h=mac#c475033
?
From what I can tell, after this happened we have been unable to land any PRs, with all test runs on the macs failing with:
The internet seems to think that we're trying to kill zombie processes, but I don't know if that's a red herring:
http://stackoverflow.com/questions/12521705/why-would-killpg-return-not-permitted-when-ownership-is-correct/12522688#12522688
The last PR we landed before all of this started was:
#12289
And all WPT / WPTRUNNER updates happened several days ago, so I'm not thinking they are related.
cc @edunham @metajack
This is currently blocking landing anything to servo master.