Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate test failures in formdata.htm #12341

Closed
KiChjang opened this issue Jul 8, 2016 · 9 comments
Closed

Investigate test failures in formdata.htm #12341

KiChjang opened this issue Jul 8, 2016 · 9 comments
Assignees

Comments

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jul 8, 2016

The XHR responseText is empty on all responses when running the WPT test. We should investigate what's wrong here. Possible areas of failure include: 1) the Python script is not returning values properly, 2) XHR is not serializing FormData properly.

cc @Scorpil

Code: components/script/dom/formdata.rs, components/script/dom/xmlhttprequest.rs
Spec: https://xhr.spec.whatwg.org/#the-send()-method
Test: components/wpt/web-platform-tests/XMLHttpRequest/formdata.htm

@Scorpil
Copy link
Contributor

@Scorpil Scorpil commented Jul 8, 2016

@KiChjang tanks, will investigate.

@KiChjang KiChjang added the C-assigned label Jul 8, 2016
@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Jul 8, 2016

Feel free to contact us at #servo on irc.mozilla.org, or leave a comment here if you have any questions.

@KiChjang KiChjang added the E-less easy label Jul 8, 2016
@Scorpil Scorpil mentioned this issue Jul 11, 2016
4 of 5 tasks complete
@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Jul 16, 2016

This appears to be a missing implementation for the send function in XHR. We currently do not send any requests that contain FormData, and in order to implement that, we'll need to fix #10605 first.

@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Jul 16, 2016

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Jul 16, 2016

We now have proper file support too, so after the union issue it should be straightforward to make formdata serialize with files inside it.

@jdm
Copy link
Member

@jdm jdm commented Aug 3, 2016

Sounds like we know the solution and it's not possible to implement it yet.

@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Dec 7, 2016

This is still blocked on #9490.

@nox
Copy link
Member

@nox nox commented Apr 8, 2017

#9490 was fixed.

@KiChjang KiChjang self-assigned this Apr 8, 2017
@KiChjang
Copy link
Member Author

@KiChjang KiChjang commented Apr 8, 2017

The test linked is no longer failing on master.

@KiChjang KiChjang closed this Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.