Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The --log-html file doesn't have the correct Reftest_Screenshots #12401

Closed
shinglyu opened this issue Jul 12, 2016 · 3 comments
Closed

The --log-html file doesn't have the correct Reftest_Screenshots #12401

shinglyu opened this issue Jul 12, 2016 · 3 comments
Labels
A-mach

Comments

@shinglyu
Copy link
Member

@shinglyu shinglyu commented Jul 12, 2016

STR:

  1. Run ./mach test-css --log-html test.log
  2. Open test.log

Expected:
The Reftest_Screenshots link for failed tests will link to the correct screenshot (using base64 encoded img link)

Actual:
All of them are empty links

selection_011
@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Jul 12, 2016

I have fixed similar thing in Gecko, if anyone can point me to the html report generation code, I can fix it.
@shinglyu
Copy link
Member Author

@shinglyu shinglyu commented Jul 12, 2016

The screenshots are generated in tests/wpt/harness/wptrunner/executors/base.py and formatted by external python module mozlog
@jdm jdm added the A-mach label Jul 12, 2016
@highfive
Copy link

@highfive highfive commented Jul 12, 2016

cc @wafflespeanut
@shinglyu shinglyu mentioned this issue Jul 12, 2016
Closed
4 of 4 tasks complete
@chenpighead chenpighead mentioned this issue Jul 19, 2016
Merged
4 of 5 tasks complete
bors-servo added a commit that referenced this issue Jul 20, 2016
@bors-servo
Auto merge of #12510 - chenpighead:update-mozlog, r=metajack
Loading status checks…
73cfab0 
Upgrade mozlog package from 3.0 to 3.3.

<!-- Please describe your changes on the following line: -->
Update mozlog to 3.3 so we can have correct reftest screenshots displayed with --log-html.
The original mozlog update bugs are listed as follows:
https://bugzilla.mozilla.org/show_bug.cgi?id=1287019
https://bugzilla.mozilla.org/show_bug.cgi?id=1287480

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12401 and #12403 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because this is just a PyPI package version bumping

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Update mozlog to 3.3.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12510)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-mach
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Upgrade mozlog package from 3.0 to 3.3.
Include screenshots in css test html log
3 participants
@jdm @shinglyu @highfive
You can’t perform that action at this time.