Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using rustc_serialize #12410

Closed
nox opened this issue Jul 12, 2016 · 5 comments
Closed

Stop using rustc_serialize #12410

nox opened this issue Jul 12, 2016 · 5 comments
Labels
I-cleanup

Comments

@nox
Copy link
Member

@nox nox commented Jul 12, 2016

There is no reason for us to use both rustc_serialize and serde.
@nox nox added the I-cleanup label Jul 12, 2016
@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Sep 17, 2017

I'd like to give this a try to get around different areas of the codebase.
@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Sep 29, 2017

@highfive: assign me
@highfive highfive added the C-assigned label Sep 29, 2017
@highfive
Copy link

@highfive highfive commented Sep 29, 2017

Hey @mhaessig! Thanks for your interest in working on this issue. It's now assigned to you!
@mhaessig mhaessig mentioned this issue Oct 2, 2017
Merged
7 of 15 tasks complete
@mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Oct 15, 2017

I have removed rustc_serialize from style_tests but realized that the code related to webdriver_server is too advanced for me at this time.

Here is a list of all the files that still use rustc_serialize:

  • components/config/Cargo.toml
  • components/config/lib.rs
  • components/config/prefs.rs
  • components/script_traits/Cargo.toml
  • components/script_traits/lib.rs
  • components/script_traits/webdriver_msg.rs
  • components/webdriver_server/Cargo.toml
  • components/webdriver_server/lib.rs
bors-servo added a commit that referenced this issue Nov 15, 2017
@bors-servo
Auto merge of #18710 - mhaessig:remove-rustc-serialize, r=jdm
Loading status checks…
2977a4e 
Replace rustc_serialize with serde_json in style_tests

#12410 Stop using rustc_serialize

Replaced rustc_serialize with serde_json in
- [ ] ~~components/config/Cargo.toml~~
- [ ] ~~components/config/lib.rs~~
- [ ] ~~components/config/prefs.rs~~
- [ ] ~~components/script_traits/Cargo.toml~~
- [ ] ~~components/script_traits/lib.rs~~
- [ ] ~~components/script_traits/webdriver_msg.rs~~
- [ ] ~~components/webdriver_server/Cargo.toml~~
- [ ] ~~components/webdriver_server/lib.rs~~
- [X] tests/unit/style/Cargo.toml
- [X] test/unit/style/lib.rs
- [X] test/unit/style/properties/scaffolding.rs

PR checks:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix (partially) #12410.
- [X] These changes do not require tests because functionality was not changed or a test itself was edited

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18710)
<!-- Reviewable:end -->
@tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Dec 25, 2017

This should remove assign and label as easy I thought.
@jdm jdm removed the C-assigned label Dec 28, 2017
@pyfisch pyfisch mentioned this issue Nov 3, 2018
Merged
bors-servo added a commit that referenced this issue Nov 7, 2018
@bors-servo
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85a631b 
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 7, 2018
@bors-servo
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b36033a 
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 7, 2018
@bors-servo
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
706ea57 
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Nov 7, 2018
@bors-servo
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
741bd8e 
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@jdm @nox @highfive @mhaessig @tigercosmos
You can’t perform that action at this time.