Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license field to Cargo.toml files #12434

Closed
asajeffrey opened this issue Jul 13, 2016 · 2 comments
Closed

Add license field to Cargo.toml files #12434

asajeffrey opened this issue Jul 13, 2016 · 2 comments
Assignees
@asajeffrey

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 13, 2016

Currently our Cargo.toml files don't contain licensing information. They should all say license = "MPL-2.0".
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jul 13, 2016

We should also write a tidy check for licensing in the Cargo.toml files. cc @jdm @aneeshusa
@asajeffrey asajeffrey self-assigned this Jul 13, 2016
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jul 14, 2016

We should also write a tidy check for licensing in the Cargo.toml files.

Relevant issues:
@asajeffrey asajeffrey mentioned this issue Jul 14, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Jul 14, 2016
@bors-servo
Auto merge of #12447 - asajeffrey:license-mpl-2.0, r=frewsxcv
Loading status checks…
650d1d1 
All our Cargo.toml files should contain an MPL-2.0 license field.

<!-- Please describe your changes on the following line: -->

Added a `license = "MPL-2.0"` field to all our `Cargo.toml` files, and added a check to `test-tidy` that the license is present.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12434
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12447)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

All our Cargo.toml files should contain an MPL-2.0 license field.
2 participants
@asajeffrey @frewsxcv
You can’t perform that action at this time.