Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a build check that fixed intermittents stay fixed #12435

Closed
asajeffrey opened this issue Jul 13, 2016 · 7 comments
Closed

Add a build check that fixed intermittents stay fixed #12435

asajeffrey opened this issue Jul 13, 2016 · 7 comments
Labels
A-testing

Comments

@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 13, 2016

We might want to add something like an etc/ci/check-fixed-intermittents.sh that makes sure that any fixed intermittents in #12424 stay fixed. Something like:

./mach test-wpt --repeat 100 --release <list of fixed intermittents>

cc @aneeshusa @ConnorGBrewster
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jul 13, 2016

IRC conversation: http://logs.glob.uno/?c=mozilla%23servo&s=13+Jul+2016&e=13+Jul+2016#c479357

TL;DR: Opera used 300 repetitions; might be worth running this nightly rather than on every merge?

cc @jgraham
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Jul 21, 2016

How about doing 10 repetitions for regular builds as a spot check, and 300 (or 100, etc.) on a nightly build to stress test?
@asajeffrey
Copy link
Member Author

@asajeffrey asajeffrey commented Jul 21, 2016

For the regular build, is 10 much better than 1? Perhaps we should just leave the regular build alone, and add a stress test to a nightly build.
@notriddle notriddle mentioned this issue Jul 28, 2016
Merged
4 of 4 tasks complete
bors-servo added a commit that referenced this issue Aug 10, 2016
@bors-servo
Auto merge of #12629 - notriddle:intermittents, r=aneeshusa
Loading status checks…
944cbbf 
Intermittents

We probably want to have Buildbot run that script.

---

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12435, #11574, and #11561
- [X] These changes do not require tests because reasons

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12629)
<!-- Reviewable:end -->
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Aug 10, 2016

Not fixed until servo/saltfs#453 lands.
@aneeshusa aneeshusa reopened this Aug 10, 2016
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Aug 10, 2016

Also, since this is running nightly, we need to set up notifications on build failure.
samuknet added a commit to samuknet/servo that referenced this issue Sep 6, 2016
@notriddle @samuknet
Add script to check for intermittent regressions
2cce7e7 
Fixes servo#12435
@cbrewster
Copy link
Member

@cbrewster cbrewster commented Apr 26, 2017

Can this be closed now?
@aneeshusa
Copy link
Member

@aneeshusa aneeshusa commented Apr 26, 2017

This has been configured and is running nightly, so closing.

However, it seems the mac-rel-intermittent hasn't passed in quite a while: http://build.servo.org/builders/mac-rel-intermittent
We may want to add alerting for these builds.
@aneeshusa aneeshusa closed this Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Intermittents
3 participants
@asajeffrey @aneeshusa @cbrewster
You can’t perform that action at this time.