Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse separate storage thread for public and private pipelines #12483
Labels
Comments
|
It may be possible to modify private_browsing.html to include tests for localStorage and sessionStorage, rather than writing a brand-new test for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Servo supports marking certain pipelines as private (like Chrome's incognito mode and Firefox's private browsing).
new_resource_threadscreates separate resource threads for public and private pipelines, but shares the same storage thread. This means that the sessionStorage and localStorage APIs are shared between public and private pipelines, which is not good. We should write a test that uses the mozbrowser API to load pages in private and public mozbrowser iframes and verifies that the storage values are not shared, and makenew_resource_threadscreate separate storage threads.Code:
components/net/resource_thread.rsTest: add a new test to
tests/wpt/mozilla/tests/mozilla/mozbrowser/, using private_browsing.html as inspiration.