Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate storage thread for public and private pipelines #12483

Open
jdm opened this issue Jul 17, 2016 · 1 comment
Open

Use separate storage thread for public and private pipelines #12483

jdm opened this issue Jul 17, 2016 · 1 comment
Assignees

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 17, 2016

Servo supports marking certain pipelines as private (like Chrome's incognito mode and Firefox's private browsing). new_resource_threads creates separate resource threads for public and private pipelines, but shares the same storage thread. This means that the sessionStorage and localStorage APIs are shared between public and private pipelines, which is not good. We should write a test that uses the mozbrowser API to load pages in private and public mozbrowser iframes and verifies that the storage values are not shared, and make new_resource_threads create separate storage threads.

Code: components/net/resource_thread.rs
Test: add a new test to tests/wpt/mozilla/tests/mozilla/mozbrowser/, using private_browsing.html as inspiration.

@jdm jdm added the A-network label Jul 17, 2016
@jdm
Copy link
Member Author

@jdm jdm commented Jul 17, 2016

It may be possible to modify private_browsing.html to include tests for localStorage and sessionStorage, rather than writing a brand-new test for this.

@nox nox self-assigned this Apr 8, 2017
@nox nox added the A-security label Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.