Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm and /css21_dev/html4/border-right-018.htm and /css-transforms-1_dev/html/transofrmed-rotateY-1.htm #12553

Closed
Manishearth opened this issue Jul 22, 2016 · 5 comments
Closed

Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm and /css21_dev/html4/border-right-018.htm and /css-transforms-1_dev/html/transofrmed-rotateY-1.htm #12553

Manishearth opened this issue Jul 22, 2016 · 5 comments
Labels
I-intermittent I-panic

Comments

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Jul 22, 2016

cc @asajeffrey looks like things are out of order during shutdown?

Tests with unexpected results:
  ▶ CRASH [expected PASS] /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ ERROR:servo: called `Result::unwrap()` on an `Err` value: RecvError
  └ thread panicked while processing panic. aborting.
@Manishearth Manishearth mentioned this issue Jul 22, 2016
Merged
3 of 3 tasks complete
@jdm jdm changed the title Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm and /css21_dev/html4/border-right-018.htm Jul 22, 2016
@jdm
Copy link
Member

@jdm jdm commented Jul 22, 2016 

  ▶ CRASH [expected PASS] /css21_dev/html4/border-right-018.htm
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ ERROR:servo: called `Result::unwrap()` on an `Err` value: RecvError
  └ thread panicked while processing panic. aborting.
@jdm jdm mentioned this issue Jul 22, 2016
Merged
3 of 3 tasks complete
@jdm jdm changed the title Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm and /css21_dev/html4/border-right-018.htm Intermittent crash in /css-transforms-1_dev/html/svg-rotate-angle-90-014.htm and /css21_dev/html4/border-right-018.htm and /css-transforms-1_dev/html/transofrmed-rotateY-1.htm Jul 27, 2016
@jdm
Copy link
Member

@jdm jdm commented Jul 27, 2016 

  ▶ CRASH [expected PASS] /css-transforms-1_dev/html/transofrmed-rotateY-1.htm
  │ 
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ Xlib:  extension "XFree86-VidModeExtension" missing on display ":0".
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ ERROR:servo: called `Result::unwrap()` on an `Err` value: RecvError
  └ thread panicked while processing panic. aborting.
@jdm jdm mentioned this issue Jul 27, 2016
Closed
@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 27, 2016

Oh good. Double panic.
@asajeffrey
Copy link
Member

@asajeffrey asajeffrey commented Jul 27, 2016

IRC chat with @jdm: http://logs.glob.uno/?c=mozilla%23servo&s=27+Jul+2016&e=27+Jul+2016#c489397

TL;DR: mutex.lock() can panic https://doc.rust-lang.org/std/sync/struct.Mutex.html#method.lock, which may be the source of the double panic. Removing the unnecessary mutex should fix the double panic.
This was referenced Jul 27, 2016
Closed
Merged
bors-servo added a commit that referenced this issue Jul 28, 2016
@bors-servo
Auto merge of #12637 - asajeffrey:constellation-use-reentrant-logging…
Loading status checks…
1606cd4 
…-mutex, r=<try>

Replaced mutex in constellation logging by a reentrant mutex.

<!-- Please describe your changes on the following line: -->

The double-panic in #12553 may be caused by using a non-reentrant lock, which panics on reetry. This PR adds a reentrant lock type (slightly annoyingly, the implementation in std isn't exported) and uses it for logging. cc @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12619.
- [X] These changes do not require tests because they are designed to remove a class of intermittents.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12637)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 28, 2016
@bors-servo
Auto merge of #12637 - asajeffrey:constellation-use-reentrant-logging…
Loading status checks…
1e63e2f 
…-mutex, r=<try>

Replaced mutex in constellation logging by a reentrant mutex.

<!-- Please describe your changes on the following line: -->

The double-panic in #12553 may be caused by using a non-reentrant lock, which panics on reetry. This PR adds a reentrant lock type (slightly annoyingly, the implementation in std isn't exported) and uses it for logging. cc @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12619.
- [X] These changes do not require tests because they are designed to remove a class of intermittents.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12637)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Jul 29, 2016
@bors-servo
Auto merge of #12637 - asajeffrey:constellation-use-reentrant-logging…
Loading status checks…
fdb1e51 
…-mutex, r=emilio

Replaced mutex in constellation logging by a reentrant mutex.

<!-- Please describe your changes on the following line: -->

The double-panic in #12553 may be caused by using a non-reentrant lock, which panics on reetry. This PR adds a reentrant lock type (slightly annoyingly, the implementation in std isn't exported) and uses it for logging. cc @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12619.
- [X] These changes do not require tests because they are designed to remove a class of intermittents.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12637)
<!-- Reviewable:end -->
@jdm
Copy link
Member

@jdm jdm commented Feb 3, 2018

These tests no longer panic, and this issue doesn't match any tests that we run.
@jdm jdm closed this Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-intermittent I-panic
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @asajeffrey @Manishearth
You can’t perform that action at this time.