Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnncessary use of $LDFLAGS in components/servo/fake-ld.sh? #12562
Labels
Comments
Closed
bors-servo
added a commit
that referenced
this issue
Oct 28, 2016
…,aneeshusa Update the Android build system A huge update for the Android build system, which makes the Android target build again. There are still some runtime issues, see #13154. CC & created by @larsbergstrom. Fixes #12562. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13945) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Filing this as a TODO reminder for myself, but open for anyone to poke at. Follow-up from #12295.
Currently this script includes
"${LDFLAGS}"as part of the arguments to thearm-linux-androideabi-gcclinker. However, based on a quick look through therustccode, it seems likerustcwill pass any linker arguments as regular args instead of through theLDFLAGSenvironment variable, and so we shouldn't need to read from that variable.This needs to be verified by taking out the reference to
$LDFLAGSin the script, cross-compiling Servo for Android, and executing the binary to make sure it builds + runs correctly.