Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependency on shared mutable state in util::opts #12581

Closed
djc opened this issue Jul 24, 2016 · 3 comments
Closed

Reduce dependency on shared mutable state in util::opts #12581

djc opened this issue Jul 24, 2016 · 3 comments
Labels

Comments

@djc
Copy link
Contributor

@djc djc commented Jul 24, 2016

As I'm familiarizing myself with the Servo code base, I came across the util::opts module. Having the option state there and having numerous crates depend on that state seems like bad design, creating a weirdly tight coupling between these crates (including compositing, gfx, layout, net and a few others) and the util::opts module.

In 29c7c5b, I already severed the dependency of the canvas crate on util::opts. With #12560, I'm trying to remove the usage of the layout_threads option from the layout_thread crate.

@nox
Copy link
Member

@nox nox commented Oct 4, 2017

The situation on that regard could still be improved.

@dralley
Copy link
Contributor

@dralley dralley commented Mar 24, 2020

Will layout 2020 address this?

@jdm
Copy link
Member

@jdm jdm commented Mar 24, 2020

This is unrelated to layout 2020. However, this is tracked in more detail in #22854.

@jdm jdm closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.