Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReduce dependency on shared mutable state in util::opts #12581
Closed
Labels
Comments
|
The situation on that regard could still be improved. |
|
Will layout 2020 address this? |
|
This is unrelated to layout 2020. However, this is tracked in more detail in #22854. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As I'm familiarizing myself with the Servo code base, I came across the
util::optsmodule. Having the option state there and having numerous crates depend on that state seems like bad design, creating a weirdly tight coupling between these crates (includingcompositing,gfx,layout,netand a few others) and theutil::optsmodule.In 29c7c5b, I already severed the dependency of the
canvascrate onutil::opts. With #12560, I'm trying to remove the usage of thelayout_threadsoption from thelayout_threadcrate.