Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Homebrew's binary packages for servo nightly #12600

Closed
paulrouget opened this issue Jul 26, 2016 · 4 comments
Closed

Provide a Homebrew's binary packages for servo nightly #12600

paulrouget opened this issue Jul 26, 2016 · 4 comments

Comments

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 26, 2016

https://github.com/Homebrew/brew/blob/master/share/doc/homebrew/Bottles.md

Nightly builds are provided as dmg, and with the browserhtml UI. It would be nice to be able to install and use Servo without browserhtml, as a Homebrew package.

The package could be updated every day along Servo nighty.

I used to provide builds via homebrew: https://github.com/paulrouget/homebrew-servo/blob/master/Formula/ This was a quick hack, not sure if we should re-use this, but it's here.

@paulrouget
Copy link
Contributor Author

@paulrouget paulrouget commented Jul 26, 2016

Log from IRC:

@larsberg> paul: nightly upload scripts are split between https://github.com/servo/servo/blob/master/etc/ci/upload_nightly.sh (which does the actual publishing of a file to s3) and the various *-nightly rules in https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

13:43 @larsberg the latter is what configures the exact build to perform and the packaging step to call and then delegates to upload_nightly to do the actual publish

bors-servo added a commit that referenced this issue Aug 14, 2016
brew package

Addressed #12600

This is just a WIP PR to see if this approach is right.

The same way night builds are uploaded every day, we'd like to offer a brew binary package as well.

Step 1 is to package a tarball along the dmg. This is done in `package_commands.py`.
Step 2 is to upload the package. Done is `update_brew.sh`.
Step 3 is to update the brew Formula. [servo-bin.rb](https://github.com/paulrouget/homebrew-servo/blob/master/servo-bin.rb.in) is updated in `update_brew.sh`.
Step 4 is to trigger `update_brew.sh` along `update_nightly.sh`. https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12688)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this issue Aug 14, 2016
brew package

Addressed #12600

This is just a WIP PR to see if this approach is right.

The same way night builds are uploaded every day, we'd like to offer a brew binary package as well.

Step 1 is to package a tarball along the dmg. This is done in `package_commands.py`.
Step 2 is to upload the package. Done is `update_brew.sh`.
Step 3 is to update the brew Formula. [servo-bin.rb](https://github.com/paulrouget/homebrew-servo/blob/master/servo-bin.rb.in) is updated in `update_brew.sh`.
Step 4 is to trigger `update_brew.sh` along `update_nightly.sh`. https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/steps.yml

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12688)
<!-- Reviewable:end -->
@nox
Copy link
Member

@nox nox commented Oct 4, 2017

@jdm Should we also close that one?

@jdm
Copy link
Member

@jdm jdm commented Oct 4, 2017

Yeah, I don't see any reason to track this work.

@jdm jdm closed this Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.