Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUncatchable panic with no backtrace #12626
Comments
|
Panics that occur after the constellation disappears are now more challenging to diagnose. I'm also concerned that |
|
cc @asajeffrey |
|
@jdm: we could log the backtrace when the panic happens, rather than expecting the constellation to do it, we just need to make sure that the panic isn't printed twice. |
|
FWIW, That's the kind of problem I tried to solve with #12591, though arguably something that works out of the box would be a much better solution. |
|
IRC chat with @jdm: http://logs.glob.uno/?c=mozilla%23servo&s=29+Jul+2016&e=29+Jul+2016#c491961 Summary: |
Print backtraces for panics, even if the constellation has closed. <!-- Please describe your changes on the following line: --> At the moment, threads rely on the constellation to print out the reason for a panic, so panics that happen after the constellation closes are dropped on the floor. cc @jdm --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12626 - [X] These changes do not require tests because they are fixing panic behaviour <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12657) <!-- Reviewable:end -->
STR:
./mach run https://samuknet.github.io/test_cases/iframeCSSRotate/ --debugb rust_panicrunwith no backtrace, and the breakpoint doesn't get hit before servo exits.